[Bugs] [Bug 1479118] New: AFR entry self heal removes a directory' s .glusterfs symlink.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1479118

            Bug ID: 1479118
           Summary: AFR entry self heal removes a directory's .glusterfs
                    symlink.
           Product: GlusterFS
           Version: 3.12
         Component: posix
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org
        Depends On: 1477169



+++ This bug was initially created as a clone of Bug #1477169 +++

Description of problem:
$subject

How reproducible:
100%

Steps to Reproduce:
-Create 1x2 replica, fuse mount it
-mkdir fuse_mount/d1
-mkdir fuse_mount/d1/dir
-mkdir fuse_mount/d2
-kill one brick and rename the dir: `mv fuse_mount/d1/dir use_mount/d2`
-Bring all bricks up and trigger heal.

Actual results:
fuse_mount/d2/dir won't have any gfid symlink.

Additional info:
For replica 3 volume, the heal won't even complete, see the .t attached.

--- Additional comment from Worker Ant on 2017-08-01 08:06:07 EDT ---

REVIEW: https://review.gluster.org/17945 (posix: add sanity checks for removing
the gfid symlink for directories) posted (#1) for review on master by
Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-02 10:59:12 EDT ---

REVIEW: https://review.gluster.org/17945 (posix: add sanity checks for removing
the gfid symlink for directories) posted (#2) for review on master by
Ravishankar N (ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2017-08-04 11:54:05 EDT ---

COMMIT: https://review.gluster.org/17945 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit 42c057a6d1a03dd2825a278393acb15d52220c8d
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon Jul 31 23:38:20 2017 +0530

    posix: add sanity checks for removing the gfid symlink for directories

    ...during mkdir and rmdir. Otherwise, during entry self-heal, the
    directory could be left out without a .glusterfs symlink causing fops like
    opendir, readdir to fail.  The only chance the missing symlink will be
    created is when a fresh lookup comes on it.

    Change-Id: I2e1cf1bce8962ea80187edd8f6d73e0a09cf9f8e
    BUG: 1477169
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17945
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1477169
[Bug 1477169] AFR entry self heal removes a directory's .glusterfs symlink.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.