[Bugs] [Bug 1476819] scripts: invalid test in S32gluster_enable_shared_storage.sh

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1476819



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17926 committed in release-3.12 by
Shyamsundar Ranganathan (srangana at redhat.com) 
------
commit 3558d83c34933aea6d53fd3ad96c0828798474cd
Author: Kaleb S. KEITHLEY <kkeithle at redhat.com>
Date:   Mon Jul 31 10:22:54 2017 -0400

    scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh

    test(1) man pages says -eq is for INTEGER compares, and = is for
    string compares.

    Also note the comment that -a and -o are ambiguous and to use
    test && test or test || test instead.

    This bug has existed since 2015! (yikes)

    Found while testing localtime logging and running glusterd in the
    foreground.

    Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
    BUG: 1476819
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: https://review.gluster.org/17926
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OqzesurVZW&a=cc_unsubscribe