[Bugs] [Bug 1477152] [Remove-brick] Few files are getting migrated eventhough the bricks crossed cluster.min-free-disk value
bugzilla at redhat.com
bugzilla at redhat.com
Wed Aug 2 15:05:10 UTC 2017
https://bugzilla.redhat.com/show_bug.cgi?id=1477152
--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17942 committed in release-3.12 by
Shyamsundar Ranganathan (srangana at redhat.com)
------
commit 87edff6e20ff3ff7bc1dc5a1b0186127effee364
Author: Susant Palai <spalai at redhat.com>
Date: Wed Jul 26 17:12:03 2017 +0530
cluster/dht: rebalance min-free-disk fix
To calculate available space on a subvolume we used to do
the following in __dht_check_free_space.
post_availspace = (dst_statfs.f_bavail * dst_statfs.f_frsize) -
stbuf->ia_size
Now to subtracting the file size from available space is tricky here.
Sometime available space will be lesser than the file size and since all
the
participating members in calculation are unsigned int, the result is a
large
number (integer overflow).
Solution: We do not need to subtract the file size from the space
available,
since fallocate would have reserved file size space already.
> Change-Id: I4f724358c44b9911933742ff3ff8d55b3dfda1cb
> BUG: 1475282
> Signed-off-by: Susant Palai <spalai at redhat.com>
> Reviewed-on: https://review.gluster.org/17876
> Smoke: Gluster Build System <jenkins at build.gluster.org>
> Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
> Reviewed-by: N Balachandran <nbalacha at redhat.com>
> CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
> Signed-off-by: Susant Palai <spalai at redhat.com>
Change-Id: I4f724358c44b9911933742ff3ff8d55b3dfda1cb
BUG: 1477152
Signed-off-by: Susant Palai <spalai at redhat.com>
Reviewed-on: https://review.gluster.org/17942
Smoke: Gluster Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LX3YiXWwL0&a=cc_unsubscribe
More information about the Bugs
mailing list