[Bugs] [Bug 1379707] New: gfapi: Fix fd ref leaks

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 27 13:33:05 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1379707

            Bug ID: 1379707
           Summary: gfapi: Fix fd ref leaks
           Product: GlusterFS
           Version: 3.9
         Component: libgfapi
          Keywords: Triaged
          Severity: high
          Assignee: skoduri at redhat.com
          Reporter: ndevos at redhat.com
        QA Contact: sdharane at redhat.com
                CC: bugs at gluster.org, sdharane at redhat.com,
                    skoduri at redhat.com
        Depends On: 1379285



+++ This bug was initially created as a clone of Bug #1379285 +++

Description of problem:

>From the code inspection, have observed that there are fd ref leaks for few
fd-based gfapi fops. 'glfs_resolve_fd' returns a fd (either existing or
migrated) with an extra ref taken. This needs to be unref'ed at the end of the
operation.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-09-26 11:35:39 CEST ---

REVIEW: http://review.gluster.org/15573 (gfapi: Fix few fd ref leaks) posted
(#1) for review on master by soumya k (skoduri at redhat.com)

--- Additional comment from Worker Ant on 2016-09-27 08:43:38 CEST ---

COMMIT: http://review.gluster.org/15573 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit d27cffab670858d7812bbb458a0833303d009b3b
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Mon Sep 26 14:54:27 2016 +0530

    gfapi: Fix few fd ref leaks

    From the code inspection, have observed that there are fd ref
    leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns
    a fd (either existing or migrated) with an extra ref taken.
    This needs to be unref'ed at the end of the operation.

    Change-Id: Id63394e3e7deafb0c8b06444f2ae847248b126db
    BUG: 1379285
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/15573
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379285
[Bug 1379285] gfapi: Fix fd ref leaks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vcSovy3fgZ&a=cc_unsubscribe


More information about the Bugs mailing list