[Bugs] [Bug 1377288] The GlusterFS Callback RPC-calls always use RPC/XID 42

bugzilla at redhat.com bugzilla at redhat.com
Wed Sep 21 03:11:50 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1377288



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15527 committed in release-3.9 by Raghavendra
G (rgowdapp at redhat.com) 
------
commit bf75a81c9732774d8ec3fbae34329481abb026f5
Author: Niels de Vos <ndevos at redhat.com>
Date:   Fri Sep 16 17:29:21 2016 +0200

    rpc: increase RPC/XID with each callback

    The RPC/XID for callbacks has been hardcoded to GF_UNIVERSAL_ANSWER. In
    Wireshark these RPC-calls are marked as "RPC retransmissions" because of
    the repeating RPC/XID. This is most confusing when verifying the
    callbacks that the upcall framework sends. There is no way to see the
    difference between real retransmissions and new callbacks.

    This change was verified by create and removal of files through
    different Gluster clients. The RPC/XID is increased on a per connection
    (or client) base. The expectations of the RPC protocol are met this way.

    > Change-Id: I2116bec0e294df4046d168d8bcbba011284cd0b2
    > BUG: 1377097
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-on: http://review.gluster.org/15524
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    (cherry picked from commit e9b39527d5dcfba95c4c52a522c8ce1f4512ac21)

    Change-Id: I2116bec0e294df4046d168d8bcbba011284cd0b2
    BUG: 1377288
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/15527
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BPOMZNqhET&a=cc_unsubscribe


More information about the Bugs mailing list