[Bugs] [Bug 1377288] New: The GlusterFS Callback RPC-calls always use RPC/XID 42
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 19 11:39:54 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1377288
Bug ID: 1377288
Summary: The GlusterFS Callback RPC-calls always use RPC/XID 42
Product: GlusterFS
Version: 3.9
Component: rpc
Keywords: Triaged
Severity: medium
Priority: medium
Assignee: ndevos at redhat.com
Reporter: ndevos at redhat.com
CC: bugs at gluster.org, rgowdapp at redhat.com,
skoduri at redhat.com
Depends On: 1377097
+++ This bug was initially created as a clone of Bug #1377097 +++
Description of problem:
The RPC/XID for callbacks has been hardcoded to GF_UNIVERSAL_ANSWER. In
Wireshark these RPC-calls are marked as "RPC retransmissions" because of
the repeating RPC/XID. This is most confusing when verifying the
callbacks that the upcall framework sends. There is no way to see the
difference between real retransmissions and new callbacks.
Version-Release number of selected component (if applicable):
all
How reproducible:
100%
Steps to Reproduce:
1. enable features.cache-invalidation on a volume
2. start a capture of network traffic (tcpdump -iany -s0 -w/tmp/out.pcap tcp)
3. create and delete some files on the mountpoint
4. inspect the .pcap file with Wireskark and filter on 'glusterfs.cbk'
5. notice the "RPC retransmission of #..." on all callback packets
Actual results:
Wireshark thinks all callback packets are a retransmission. This is not the
case, the contents of the packets are different (except for the rpc.xid).
Expected results:
The rpc.xid should increase for each callback that gets sent (per client).
Additional info:
--- Additional comment from Worker Ant on 2016-09-18 14:15:34 CEST ---
REVIEW: http://review.gluster.org/15524 (rpc: increase RPC/XID with each
callback) posted (#1) for review on master by Niels de Vos (ndevos at redhat.com)
--- Additional comment from Niels de Vos on 2016-09-18 14:16 CEST ---
tcpdump with the patch applied, showing the RPC/XID increasing per client
(different ports, all on the same localhost)
--- Additional comment from Worker Ant on 2016-09-19 11:32:08 CEST ---
COMMIT: http://review.gluster.org/15524 committed in master by Raghavendra G
(rgowdapp at redhat.com)
------
commit e9b39527d5dcfba95c4c52a522c8ce1f4512ac21
Author: Niels de Vos <ndevos at redhat.com>
Date: Fri Sep 16 17:29:21 2016 +0200
rpc: increase RPC/XID with each callback
The RPC/XID for callbacks has been hardcoded to GF_UNIVERSAL_ANSWER. In
Wireshark these RPC-calls are marked as "RPC retransmissions" because of
the repeating RPC/XID. This is most confusing when verifying the
callbacks that the upcall framework sends. There is no way to see the
difference between real retransmissions and new callbacks.
This change was verified by create and removal of files through
different Gluster clients. The RPC/XID is increased on a per connection
(or client) base. The expectations of the RPC protocol are met this way.
Change-Id: I2116bec0e294df4046d168d8bcbba011284cd0b2
BUG: 1377097
Signed-off-by: Niels de Vos <ndevos at redhat.com>
Reviewed-on: http://review.gluster.org/15524
Smoke: Gluster Build System <jenkins at build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1377097
[Bug 1377097] The GlusterFS Callback RPC-calls always use RPC/XID 42
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EzQlT1I9ms&a=cc_unsubscribe
More information about the Bugs
mailing list