[Bugs] [Bug 1369124] fix unused variable warnings from out-of-tree builds generate XDR headers and source files i...

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 15 15:43:12 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1369124



--- Comment #195 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15482 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 36748550398f5e4a0bcdc603ac70a62453e86979
Author: Kaleb S. KEITHLEY <kkeithle at redhat.com>
Date:   Tue Sep 13 05:57:32 2016 -0400

    protocol/client: fix op_errno handling, was unused variable

    see comment in patch set one. Match the general logic flow of the
    other fop-cbks and eliminate the unused variable and its associated
    warning

    also see comment in patch set seven, re: correct handling of
    client_process_response(); and the associated BZ
    https://bugzilla.redhat.com/show_bug.cgi?id=1376328

    http://review.gluster.org/14085 fixes a "pragma leak" where the
    generated rpc/xdr headers have a pair of pragmas that disable these
    warnings. With the warnings disabled, many unused variables have
    crept into the code base.

    And 14085 won't pass its own smoke test until all these warnings are
    fixed.

    BUG: 1369124
    Change-Id: I7421ba3550770acc5564b7d6aba3290e027591f2
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: http://review.gluster.org/15482
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eF2zGXrKxI&a=cc_unsubscribe


More information about the Bugs mailing list