[Bugs] [Bug 1375570] New: Detach tier commit is allowed when detach tier start goes into failed state

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 13 12:43:22 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1375570

            Bug ID: 1375570
           Summary: Detach tier commit is allowed when detach tier start
                    goes into failed state
           Product: GlusterFS
           Version: 3.9
         Component: tiering
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: hgowtham at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org, dlambrig at redhat.com,
                    hgowtham at redhat.com, kramdoss at redhat.com
        Depends On: 1374412, 1374584, 1375474, 1375565



+++ This bug was initially created as a clone of Bug #1375565 +++

+++ This bug was initially created as a clone of Bug #1375474 +++

+++ This bug was initially created as a clone of Bug #1374584 +++

+++ This bug was initially created as a clone of Bug #1374412 +++

Description of problem:
Detach tier commit operation should not be allowed when detach tier start
operation has gone into failed state. There might be files which are not moved
from hot to cold tier when a detach tier operation fails. Allowing to commit
the operation removes off the hot tier bricks, thereby making those data in hot
tier inaccessible.

Version-Release number of selected component (if applicable):
rpm -qa | grep 'gluster'
glusterfs-cli-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-server-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
python-gluster-3.8.3-0.1.git2ea32d9.el7.centos.noarch
glusterfs-client-xlators-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-fuse-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
nfs-ganesha-gluster-next.20160813.2f47e8a-1.el7.centos.x86_64
glusterfs-libs-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-api-3.8.3-0.1.git2ea32d9.el7.centos.x86_64
glusterfs-ganesha-3.8.3-0.1.git2ea32d9.el7.centos.x86_64

How reproducible:
Always

Steps to Reproduce:
1. create a tier vol and start detach tier operation
2. kill a brick on hot tier and restore it after a while to fail the detach
tier operation
3. Try detach tier commit

Actual results:
detach tier commit is allowed

Expected results:
detach tier commit should not be allowed

Additional info:

--- Additional comment from Worker Ant on 2016-09-09 03:02:31 EDT ---

REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach
failure and in-progress) posted (#1) for review on master by hari gowtham
(hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2016-09-09 05:24:31 EDT ---

REVIEW: http://review.gluster.org/15438 (Tier: failing detach commit on detach
failure and in-progress) posted (#2) for review on master by hari gowtham
(hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2016-09-12 09:27:36 EDT ---

COMMIT: http://review.gluster.org/15438 committed in master by Dan Lambright
(dlambrig at redhat.com) 
------
commit 1afa0bd91fd23b5131ccc1cceb814a061ac99096
Author: hari gowtham <hgowtham at redhat.com>
Date:   Fri Sep 9 12:26:52 2016 +0530

    Tier: failing detach commit on detach failure and in-progress

    PROBLEM: if detach status has failed or if it remains in progress
    we allow detach commit to happen. only detach force should
    be allowed.

    FIX: check the detach status for failure or inprogress and disallow
    with the apt error message.

    Change-Id: Ib97d540fec67717bb55c18d133187c665cf69ef1
    BUG: 1374584
    Signed-off-by: hari gowtham <hgowtham at redhat.com>
    Reviewed-on: http://review.gluster.org/15438
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Tested-by: hari gowtham <hari.gowtham005 at gmail.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>
    Tested-by: Dan Lambright <dlambrig at redhat.com>

--- Additional comment from Worker Ant on 2016-09-13 08:05:15 EDT ---

REVIEW: http://review.gluster.org/15491 (Tier: failing detach commit on detach
failure and in-progress) posted (#1) for review on release-3.7 by hari gowtham
(hari.gowtham005 at gmail.com)

--- Additional comment from Worker Ant on 2016-09-13 08:29:36 EDT ---

REVIEW: http://review.gluster.org/15492 (Tier: failing detach commit on detach
failure and in-progress) posted (#1) for review on release-3.8 by hari gowtham
(hari.gowtham005 at gmail.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1374412
[Bug 1374412] Detach tier commit is allowed when detach tier start goes
into failed state
https://bugzilla.redhat.com/show_bug.cgi?id=1374584
[Bug 1374584] Detach tier commit is allowed when detach tier start goes
into failed state
https://bugzilla.redhat.com/show_bug.cgi?id=1375474
[Bug 1375474] Detach tier commit is allowed when detach tier start goes
into failed state
https://bugzilla.redhat.com/show_bug.cgi?id=1375565
[Bug 1375565] Detach tier commit is allowed when detach tier start goes
into failed state
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list