[Bugs] [Bug 1375537] New: gf_event python fails with ImportError

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1375537

            Bug ID: 1375537
           Summary: gf_event python fails with ImportError
           Product: GlusterFS
           Version: 3.9
         Component: eventsapi
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
        Depends On: 1374587
            Blocks: 1351589



+++ This bug was initially created as a clone of Bug #1374587 +++

Description of problem:

Calling gf_event causes import error for python-requests library. 

ImportError: No module named requests

As a workaround, we can install python-requests but this library not required
if we are not using Events feature.

Traceback (most recent call last):
  File "/usr/local/libexec/glusterfs/python/syncdaemon/syncdutils.py", line
313, in twrap
    tf(*aa)
  File "/usr/local/libexec/glusterfs/python/syncdaemon/monitor.py", line 403,
in wmon
    slave_host, master)
  File "/usr/local/libexec/glusterfs/python/syncdaemon/monitor.py", line 384,
in monitor
    brick_path=w[0]['dir'])
  File "/usr/local/libexec/glusterfs/python/syncdaemon/syncdutils.py", line
519, in gf_event
    from events.gf_event import gf_event as gfevent
  File "/usr/local/libexec/glusterfs/events/gf_event.py", line 19, in <module>
    from utils import logger, setup_logger, get_config
  File "/usr/local/libexec/glusterfs/events/utils.py", line 16, in <module>
    import requests
ImportError: No module named requests

--- Additional comment from Worker Ant on 2016-09-09 03:19:09 EDT ---

REVIEW: http://review.gluster.org/15439 (eventsapi: Add conditional import for
requests library) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-09-09 08:59:54 EDT ---

COMMIT: http://review.gluster.org/15439 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit aa742fd88e08eeb807dba1cb98402e8813ec6797
Author: Aravinda VK <avishwan at redhat.com>
Date:   Fri Sep 9 12:40:38 2016 +0530

    eventsapi: Add conditional import for requests library

    requests lib is used only during publishing event. gf_event python
    imports utils.py, and indirectly imports requests lib even though
    it is not required while sending event to eventsd.

    Moved "import requests" inside the "plugin_webhook" function.

    BUG: 1374587
    Change-Id: Ie3c8088b43d4d7952d01352731999bf8519c73c4
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/15439
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Kotresh HR <khiremat at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1351589
[Bug 1351589] [RFE] Eventing for Gluster
https://bugzilla.redhat.com/show_bug.cgi?id=1374587
[Bug 1374587] gf_event python fails with ImportError
-- 
You are receiving this mail because:
You are the assignee for the bug.