[Bugs] [Bug 1375096] New: dht: Update stbuf from servers having layout

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1375096

            Bug ID: 1375096
           Summary: dht: Update stbuf from servers having layout
           Product: GlusterFS
           Version: 3.8.4
         Component: distribute
          Assignee: bugs at gluster.org
          Reporter: spalai at redhat.com
                CC: bugs at gluster.org
        Depends On: 1365740



+++ This bug was initially created as a clone of Bug #1365740 +++

Description of problem:
 Update stbuf from servers with layout since this is an indication that the
server is not a newly added brick. Otherwise uid/gid heal may choose the added
brick as the source of heal.

--- Additional comment from Vijay Bellur on 2016-08-10 11:50:23 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#1) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Vijay Bellur on 2016-08-11 13:49:46 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#2) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Vijay Bellur on 2016-08-11 14:15:52 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#3) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Worker Ant on 2016-08-25 09:21:54 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#4) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Worker Ant on 2016-09-06 12:05:35 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#5) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Worker Ant on 2016-09-06 17:59:43 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#6) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Worker Ant on 2016-09-09 11:14:28 MVT ---

REVIEW: http://review.gluster.org/15126 (dht: udpate stbuf from servers those
have layout) posted (#7) for review on master by Susant Palai
(spalai at redhat.com)

--- Additional comment from Worker Ant on 2016-09-09 17:20:25 MVT ---

COMMIT: http://review.gluster.org/15126 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 36af81ac7cb2d459f9bfc0c436f0038a68f85235
Author: Susant Palai <spalai at redhat.com>
Date:   Mon Aug 8 17:05:10 2016 +0530

    dht: udpate stbuf from servers those have layout

    Problem: For healing of uid/gid we check if local->stbuf.ia_ctime is
    lesser than stbuf->ia_ctime (received from brick). If yes then uid/gid
    is updated to local->prebuf(source of healing).

    But we merge local->stbuf also form the newly added brick. So if we
    receive response from the newly added brick first and update the
    local->stbuf, then local->prebuf will remain empty since the newly added
    brick will have the latest ctime among all servers. And this can result
    in healing wrong uid/gids to the rest of servers.

    Hence, we should update local->stbuf from servers with a layout which
    will ignore merging stbufs from newly added bricks.

    Change-Id: If4b64f75a0ea669abdbe9f5a3d1d18ff19374c2f
    BUG: 1365740
    Signed-off-by: Susant Palai <spalai at redhat.com>
    Reviewed-on: http://review.gluster.org/15126
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365740
[Bug 1365740] dht: Update stbuf from servers having layout
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.