[Bugs] [Bug 1374580] New: Geo-rep worker Faulty with OSError: [Errno 21] Is a directory

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1374580

            Bug ID: 1374580
           Summary: Geo-rep worker Faulty with OSError: [Errno 21] Is a
                    directory
           Product: GlusterFS
           Version: 3.8.3
         Component: geo-replication
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: bugs at gluster.org
        Depends On: 1365791
            Blocks: 1374579



+++ This bug was initially created as a clone of Bug #1365791 +++

Description of problem:
During rename if Source and destination exists with same inode then Geo-rep
sends unlink for the source. Geo-rep is failing with EISDIR error during unlink

Traceback (most recent call last):
  File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 113, in worker
    res = getattr(self.obj, rmeth)(*in_data[2:])
  File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 772, in
entry_ops
    os.unlink(entry)
OSError: [Errno 21] Is a directory:
'.gfid/12711ebf-7fdc-4f4b-9850-2d75581eb452/New folder'

--- Additional comment from Vijay Bellur on 2016-08-10 04:42:33 EDT ---

REVIEW: http://review.gluster.org/15132 (geo-rep: Handle EISDIR error during
Unlink) posted (#1) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-08-25 04:17:56 EDT ---

REVIEW: http://review.gluster.org/15132 (geo-rep: Handle EISDIR error during
Unlink) posted (#2) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-08-29 02:40:13 EDT ---

REVIEW: http://review.gluster.org/15132 (geo-rep: Handle EISDIR error during
Unlink) posted (#3) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-09-08 12:16:08 EDT ---

COMMIT: http://review.gluster.org/15132 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 8a6236e4cfc7bf86e881e5c770a19040a6060ad0
Author: Aravinda VK <avishwan at redhat.com>
Date:   Wed Aug 10 14:02:09 2016 +0530

    geo-rep: Handle EISDIR error during Unlink

    During Rename, If Source and Target has same inode then
    Geo-rep unlinks source. But if source is a directory then
    this will fail with below traceback

    Traceback (most recent call last):
      File "/usr/libexec/glusterfs/python/syncdaemon/repce.py", line 113, in
worker
        res = getattr(self.obj, rmeth)(*in_data[2:])
      File "/usr/libexec/glusterfs/python/syncdaemon/resource.py", line 772,
        in entry_ops
        os.unlink(entry)
    OSError: [Errno 21] Is a directory:
'.gfid/12711ebf-7fdc-4f4b-9850-2d75581eb
       452/New folder'

    With this patch, if EISDIR, rmdir is tried. Logs error in Slave log in case
    of ENOTEMPTY.

    BUG: 1365791
    Change-Id: I099af4192adac5125c0a23988ceb6506f91e987f
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/15132
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kotresh HR <khiremat at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365791
[Bug 1365791] Geo-rep worker Faulty with OSError: [Errno 21] Is a directory
https://bugzilla.redhat.com/show_bug.cgi?id=1374579
[Bug 1374579] Geo-rep worker Faulty with OSError: [Errno 21] Is a directory
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.