[Bugs] [Bug 1357760] Geo-rep silently ignores config parser errors

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1357760



--- Comment #4 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/14947 committed in release-3.8 by Aravinda VK
(avishwan at redhat.com) 
------
commit 26b4f38176d15f996b809511ce1adf5f0ea8234e
Author: Aravinda VK <avishwan at redhat.com>
Date:   Thu Jun 23 11:53:36 2016 +0530

    geo-rep: Handle Config parser errors

    Python ConfigParser lib has two methods, readfp and read, it should
    be used as follows.

        readfp(open("defaults.conf"))
        read("custom.conf")

    ConfigParser.read(path) ignores any file errors, which is intentional
    since errors are handled while loading default config.

    Geo-rep uses only one config file(Session config in Master side and
    Template config on Slave side) so we should use readfp to avoid
    skipping OS errors.

    config.read is retained in case of `--config-set-rx` where glusterd
    creates new template config file.

    > Signed-off-by: Aravinda VK <avishwan at redhat.com>
    > Reviewed-on: http://review.gluster.org/14777
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

    (cherry picked from commit d94bf608b16b82f2c8f8588a96459cb746773b32)

    BUG: 1357760
    Change-Id: I15a14d3743facd7b8c7af0edc70fdefaa43efd04
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/14947
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=59MiS0Czxb&a=cc_unsubscribe