[Bugs] [Bug 1389910] New: Allow ":" as brick path name

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1389910

            Bug ID: 1389910
           Summary: Allow ":" as brick path name
           Product: GlusterFS
           Version: mainline
         Component: cli
          Assignee: bugs at gluster.org
          Reporter: alessandro.corbelli at guest.it
                CC: bugs at gluster.org



gluster doesn't allow the use of ":" in the brick path name

# gluster volume replace-brick gv0 1.2.3.4:/export/brick1/brick
1.2.3.4:/export/pci-0000:01:00.0-scsi-0:0:2:0/brick commit force
wrong brick type: 1.2.3.4:/export/pci-0000:01:00.0-scsi-0:0:2:0/brick,
use <HOSTNAME>:<export-dir-abs-path>
Usage: volume replace-brick <VOLNAME> <SOURCE-BRICK> <NEW-BRICK> {commit force}


There are 2 possible solutions to this:

1) get the hostname up to the first occurence of ":" and leave the rest as
brick path. This would breack IPv6 compatibility and IPv6 users should use
hostnames and not IPv6 addresses (that containes ":")

2) get the hostname up to the first occurrence of ":/". This preserve the IPv6
compatibility (as there is no '/' in an IPv6 addresses) and should also fix
this bug as the brick path must always be an absolute path (thus always start
with a '/')

The use of ":" in brick path is usefull when you want to call each brick as the
physical path of the underlying disk, like for ZFS. In my test case, the
"pci-0000:01:00.0-scsi-0:0:2:0" is the disk located at device
"pci-0000:01:00.0-scsi-0:0:2:0". When you have multiple bricks per servers and
multiple servers for each cluster, referring to disk path is better than
calling "brick1" or "brick2"
"brick1" is hard to remember, while with
"1.2.3.4:/pci-0000:01:00.0-scsi-0:0:2:0" you know immediatly that is disk at
slot number2 on server 1.2.3.4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.