[Bugs] [Bug 1389197] New: glusterd: Display proper error message and fail the command if S32gluster_enable_shared_storage.sh hook script is not present during gluster volume set all cluster.enable-shared-storage <enable/disable> command

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1389197

            Bug ID: 1389197
           Summary: glusterd: Display proper error message and fail the
                    command if S32gluster_enable_shared_storage.sh hook
                    script is not present during gluster volume set all
                    cluster.enable-shared-storage <enable/disable> command
           Product: GlusterFS
           Version: 3.9
         Component: glusterd
          Keywords: Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: asengupt at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    jflory at datapipe.com
        Depends On: 1377448, 1388348, 1389168



+++ This bug was initially created as a clone of Bug #1388348 +++

+++ This bug was initially created as a clone of Bug #1377448 +++

Description of problem:


Version-Release number of selected component (if applicable): GlusterFS 3.8.4
(latest)

How reproducible: Always


Steps to Reproduce:
1. Run command: "gluster volume set all cluster.enable-shared-storage enable"

Actual results:
1. The running Volume now lists "cluster.enable-shared-storage: enable"
a. The command returned success.
2. However the shared volume was not created.

Expected results:
1. When the command fails, a failure return code is expected.
a. With a relevant description.
2. It is expected that the command will create the shared volume.

Additional info:

OS: Debian Jessie

1. Rebooting did not help.
2. Rebuilding the clustered data volume did not help.
3. Clearing files in /var/run/gluster did not help. 
4. Logs lack error messages except:
   readv on /var/run/gluster/d373e2b2e599fb58e944558312eb1ae5.socket failed
(Invalid argument)

--- Additional comment from Avra Sengupta on 2016-10-21 05:57:32 EDT ---

Was the hook script
/var/lib/glusterd/hooks/1/set/post/S32gluster_enable_shared_storage.sh present
at the time this was seen. Hook scripts get deleted when we clean up
/var/lib/glusterd, and need to be installed again.

--- Additional comment from Jay Flory on 2016-10-23 11:38:06 EDT ---

1. At this point I am not able to tell if it was installed.
a. I have long since moved on and installed by other means.
2. Where is this documented about the scripts?
3. If the scripts are missing but needed, the command should fail and
specifically state that the scripts are missing.
a. The command should not fail but report success.

--- Additional comment from Avra Sengupta on 2016-10-24 04:55:18 EDT ---

I agree, maybe we can edit the summary of this bug to reflect the same, and
make the necessary changes so that the command fails with the appropriate
message.

--- Additional comment from Avra Sengupta on 2016-10-25 02:46:39 EDT ---

Based on comment #3, updating the summary of the bug.

--- Additional comment from Worker Ant on 2016-10-25 03:24:56 EDT ---

REVIEW: http://review.gluster.org/15718 (glusterd/shared storage: Check for
hook-script at staging) posted (#1) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Worker Ant on 2016-10-27 03:30:57 EDT ---

COMMIT: http://review.gluster.org/15718 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 29587a91716e1e55bd172d63340c40249fb343c9
Author: Avra Sengupta <asengupt at redhat.com>
Date:   Tue Oct 25 12:44:29 2016 +0530

    glusterd/shared storage: Check for hook-script at staging

    Check if S32gluster_enable_shared_storage.sh is present
    at /var/lib/glusterd/hooks/1/set/post/ at staging
    before proceeding with the command. Fail the command
    with the appropriate error message in case it is not
    present.

    Change-Id: I84e3912f1cdffb927f8a40d74d52be43ee69388b
    BUG: 1388348
    Signed-off-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-on: http://review.gluster.org/15718
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377448
[Bug 1377448] glusterd: Display proper error message and fail the command
if S32gluster_enable_shared_storage.sh hook script is not present during
gluster volume set all cluster.enable-shared-storage <enable/disable>
command
https://bugzilla.redhat.com/show_bug.cgi?id=1388348
[Bug 1388348] glusterd: Display proper error message and fail the command
if S32gluster_enable_shared_storage.sh hook script is not present during
gluster volume set all cluster.enable-shared-storage <enable/disable>
command
https://bugzilla.redhat.com/show_bug.cgi?id=1389168
[Bug 1389168] glusterd: Display proper error message and fail the command
if S32gluster_enable_shared_storage.sh hook script is not present during
gluster volume set all cluster.enable-shared-storage <enable/disable>
command
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.