[Bugs] [Bug 1387099] New: Boolean attributes are published as string

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1387099

            Bug ID: 1387099
           Summary: Boolean attributes are published as string
           Product: GlusterFS
           Version: 3.9
         Component: eventsapi
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
        Depends On: 1379328



+++ This bug was initially created as a clone of Bug #1379328 +++

Description of problem:
Boolean attributes like "force" is published as {"force": "1"} instead of
{"force": true}

--- Additional comment from Worker Ant on 2016-09-26 07:47:19 EDT ---

REVIEW: http://review.gluster.org/15574 (eventsapi: Auto convert Boolean and
Int attributes) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-09-29 02:25:11 EDT ---

REVIEW: http://review.gluster.org/15574 (eventsapi: Auto convert Boolean and
Int attributes) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-10-13 01:49:14 EDT ---

REVIEW: http://review.gluster.org/15574 (eventsapi: Auto convert Boolean and
Int attributes) posted (#3) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-10-20 02:10:49 EDT ---

COMMIT: http://review.gluster.org/15574 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit a482645865af56b8d34a17430649c3c646f3d450
Author: Aravinda VK <avishwan at redhat.com>
Date:   Mon Sep 26 17:08:31 2016 +0530

    eventsapi: Auto convert Boolean and Int attributes

    Before publishing in JSON format, automatically convert the
    attribute to "bool" or "int" if configured.

    For example, instead of sending force="1", convert to bool and
    send as force=True

    {
        "event": "VOLUME_START",
        "name" : "gv1",
        "force": "1"
    }

    Convert to,

    {
        "event": "VOLUME_START",
        "name" : "gv1",
        "force": true
    }

    BUG: 1379328
    Change-Id: Iabc51fd61abc267a7c8dcf0aeac6b3c722d89649
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/15574
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379328
[Bug 1379328] Boolean attributes are published as string
-- 
You are receiving this mail because:
You are the assignee for the bug.