[Bugs] [Bug 1386338] New: pmap_signin event fails to update brickinfo-> signed_in flag

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1386338

            Bug ID: 1386338
           Summary: pmap_signin event fails to update brickinfo->signed_in
                    flag
           Product: GlusterFS
           Version: 3.9
         Component: glusterd
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1385575



+++ This bug was initially created as a clone of Bug #1385575 +++

Description of problem:

While testing gluster get-state CLI, we figured out that brickinfo->signed_in
field of a given brick of a volume is marked as false even if the pmap_signin
has successfully happened. 

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-10-17 06:46:22 EDT ---

REVIEW: http://review.gluster.org/15655 (glusterd: set the brickinfo->port
before spawning the bricks) posted (#1) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Worker Ant on 2016-10-18 10:16:21 EDT ---

COMMIT: http://review.gluster.org/15655 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit bac42476a14a16089e7185c7a250dfae43be6106
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Mon Oct 17 16:08:41 2016 +0530

    glusterd: set the brickinfo->port before spawning the bricks

    As of now, when glusterd spawns a brick process, post spawning, the
brickinfo's
    port is set. The side effect of this is it opens up an window where the
    pmap_signin event can be initiated by the brick to glusterd and glusterd
fails
    to update signed_in flag since the brickinfo port is still 0 and the
comparison
    of port and brickinfo->port fails.

    As a solution, set the brickinfo->port post pmap_registry_alloc and if the
brick
    spawn fails reset it to 0. This logic applies for rdma port too.

    Change-Id: I00a13d4c6d6809ebd19a972aa13e71ee5eac7e35
    BUG: 1385575
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/15655
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Samikshan Bairagya <samikshan at gmail.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385575
[Bug 1385575] pmap_signin event fails to update brickinfo->signed_in flag
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.