[Bugs] [Bug 1384460] New: segment fault while join thread reaper_thr in fini()

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1384460

            Bug ID: 1384460
           Summary: segment fault while join thread reaper_thr in fini()
           Product: Red Hat Gluster Storage
           Version: 3.2
         Component: upcall
          Keywords: Triaged
          Severity: high
          Assignee: skoduri at redhat.com
          Reporter: sraj at redhat.com
        QA Contact: sraj at redhat.com
                CC: bugs at gluster.org, jthottan at redhat.com,
                    ndevos at redhat.com, pgurusid at redhat.com,
                    rhs-bugs at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1369524, 1371196



+++ This bug was initially created as a clone of Bug #1371196 +++

+++ This bug was initially created as a clone of Bug #1369524 +++

Description of problem:

reaper_thr thread may not be started according to option 'cache-invalidation',
if it's not started, the following code in fini() will cause segment fault:

        priv->fini = 1; 

        pthread_join (priv->reaper_thr, NULL);

--- Additional comment from Worker Ant on 2016-08-23 18:30:26 CEST ---

REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while
join thread reaper_thr in fini()) posted (#1) for review on master by Anonymous
Coward

--- Additional comment from Worker Ant on 2016-08-25 22:50:09 CEST ---

REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while
join thread reaper_thr in fini()) posted (#2) for review on master by Niels de
Vos (ndevos at redhat.com)

--- Additional comment from Worker Ant on 2016-08-29 14:13:54 CEST ---

COMMIT: http://review.gluster.org/15298 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 7f0042dce94edb58c92662d9e4f852ba006d12dc
Author: Ryan Ding <ryan.ding at open-fs.com>
Date:   Wed Aug 24 00:24:30 2016 +0800

    features/upcall: segment fault while join thread reaper_thr in fini()

    reaper_thr thread may not be started according to option
    'cache-invalidation', if it's not started, join it in fini will cause a
    segment fault.

    Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    BUG: 1369524
    Signed-off-by: Ryan Ding <ryan.ding at open-fs.com>
    [ndevos: check .reaper_init_done and make it a boolean]
    Reviewed-on: http://review.gluster.org/15298
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: soumya k <skoduri at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

--- Additional comment from Worker Ant on 2016-08-29 10:31:02 EDT ---

REVIEW: http://review.gluster.org/15337 (features/upcall: segment fault while
join thread reaper_thr in fini()) posted (#1) for review on release-3.7 by
Niels de Vos (ndevos at redhat.com)

--- Additional comment from Worker Ant on 2016-09-05 05:07:25 EDT ---

COMMIT: http://review.gluster.org/15337 committed in release-3.7 by Niels de
Vos (ndevos at redhat.com) 
------
commit 337fb7f4e14240fa6553e34094bc07f24fe897b6
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Aug 29 16:30:16 2016 +0200

    features/upcall: segment fault while join thread reaper_thr in fini()

    reaper_thr thread may not be started according to option
    'cache-invalidation', if it's not started, join it in fini will cause a
    segment fault.

    Cherry picked from commit 7f0042dce94edb58c92662d9e4f852ba006d12dc:
    > Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    > BUG: 1369524
    > Signed-off-by: Ryan Ding <ryan.ding at open-fs.com>
    > [ndevos: check .reaper_init_done and make it a boolean]
    > Reviewed-on: http://review.gluster.org/15298
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: soumya k <skoduri at redhat.com>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

    Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    BUG: 1371196
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/15337
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Ryan Ding <ryan.ding at open-fs.com>
    Reviewed-by: soumya k <skoduri at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1369524
[Bug 1369524] segment fault while join thread reaper_thr in fini()
https://bugzilla.redhat.com/show_bug.cgi?id=1371196
[Bug 1371196] segment fault while join thread reaper_thr in fini()
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ac1PjHFgiO&a=cc_unsubscribe