[Bugs] [Bug 1384345] New: usage text is wrong for use-readdirp mount default

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1384345

            Bug ID: 1384345
           Summary: usage text is wrong for use-readdirp mount default
           Product: GlusterFS
           Version: 3.8
         Component: fuse
          Keywords: EasyFix, Triaged
          Assignee: bugs at gluster.org
          Reporter: anraj at redhat.com
                CC: bugs at gluster.org, dblack at redhat.com, ndevos at redhat.com
        Depends On: 1222915
            Blocks: 1222917, 1222148



+++ This bug was initially created as a clone of Bug #1222915 +++

+++ This bug was initially created as a clone of Bug #1222148 +++

glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL",
OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come
from each translator's volume_options struct so changes don't come from
multiple places. Perhaps that struct should be in include files?

--- Additional comment from Vijay Bellur on 2016-06-02 17:02:58 EDT ---

REVIEW: http://review.gluster.org/14622 (Corrected default text for
ARGP_FUSE_USE_READDIRP_KEY Changed from "off" to "yes" per BZ 1222915) posted
(#1) for review on master by Dustin Black (dblack at redhat.com)

--- Additional comment from Dustin Black on 2016-06-02 17:05:30 EDT ---

http://review.gluster.org/#/c/14622/

--- Additional comment from Vijay Bellur on 2016-06-06 11:01:45 EDT ---

COMMIT: http://review.gluster.org/14622 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 66cc92c25ec2680e50a6b3edda2e027635c380db
Author: Dustin Black <dblack at redhat.com>
Date:   Thu Jun 2 17:01:32 2016 -0400

    Corrected default text for ARGP_FUSE_USE_READDIRP_KEY
    Changed from "off" to "yes" per BZ 1222915

    Change-Id: Idffffee621560adb4cc02c1001d1ae21ca11941f
    BUG: 1222915
    Signed-off-by: Dustin Black <dblack at redhat.com>
    Reviewed-on: http://review.gluster.org/14622
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1222148
[Bug 1222148] usage text is wrong for use-readdirp mount default
https://bugzilla.redhat.com/show_bug.cgi?id=1222915
[Bug 1222915] usage text is wrong for use-readdirp mount default
https://bugzilla.redhat.com/show_bug.cgi?id=1222917
[Bug 1222917] usage text is wrong for use-readdirp mount default
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.