[Bugs] [Bug 1383694] GlusterFS fails to build on old Linux distros with linux/ oom.h missing

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 12 11:01:32 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1383694



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15623 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com) 
------
commit 92f6ef8a63411eb80d4cc402b4285f87d745226f
Author: Oleksandr Natalenko <onatalen at redhat.com>
Date:   Wed Sep 28 14:29:23 2016 +0200

    glusterfsd/main: fix OOM adjustment for older kernels

    Milind Changire reported that GlusterFS fails to build on RHEL5
    because linux/oom.h is unavailable.

    Milind's initial patch disables OOM adjustment completely
    for those environments that do not have this header. However,
    I'd take another approach that:

    1) checks for linux/oom.h in compile-time and defines necessary
    constants if the header is not present;
    2) checks for available OOM API in /proc in run-time and uses it
    accordingly.

    This allows OOM to be adjusted properly on RHEL5 (the kernel is pretty new
    to present /proc API for that) as well as RHEL6 (the kernel has many thing
    backported including new /proc API).

    > Reviewed-on: http://review.gluster.org/15587
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>
    > Tested-by: Oleksandr Natalenko <oleksandr at natalenko.name>

    Change-Id: I1bc610586872d208430575c149a7d0c54bd82370
    BUG: 1383694
    Signed-off-by: Oleksandr Natalenko <onatalen at redhat.com>
    Reviewed-on: http://review.gluster.org/15623
    Tested-by: Oleksandr Natalenko <oleksandr at natalenko.name>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list