[Bugs] [Bug 1347715] removal of file from nfs mount crashs ganesha server

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1347715



--- Comment #10 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15602 committed in release-3.7 by Kaushal M
(kaushal at redhat.com) 
------
commit 55c92db32ba7d88359f0562953a3a6d8874dd1a5
Author: Niels de Vos <ndevos at redhat.com>
Date:   Fri Jun 10 18:23:43 2016 +0530

    gfapi: redesign the public interface for upcall consumers

    The glfs_callback_arg and glfs_callback_inode_arg were allocated by
    gfapi, and expected to be free()'d by the application. However it is not
    reasonable to expect that applications use the same memory allocator to
    as the compiled libgfapi.so. For instance, it is possible that gfapi
    uses glibc malloc/free, and an application like NFS-Ganesha the versions
    from jemalloc. Mismatching of the malloc() and free() functions causes
    segmentation faults at best.

    In order to prevent problems like this in the future, the API for
    applications that consume upcalls has been remodeled. Any of the
    structures that gfapi allocates, should be free'd with glfs_free(). The
    members of the structures can not be accessed directly anymore, each
    has its own function to access now.

    Correcting the naming of the functions, structures and constants is a
    continuation of commit 2775dc64101ed37c8d9809bf9852dbf0746ee2b6. These
    new improvements not only have correct prefixes for the functions and
    structures, the naming also reflects more to the upcall framework and
    does not use "callback" anymore.

    Cherry picked from commit 4721188a154acd9a0a4c096d8d73e97f3bf1b2a9:
    > Change-Id: I2b8bd5a0a82036d2abea1a217f5e5975a1d4fe93
    > BUG: 1344714
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-on: http://review.gluster.org/14701
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    > Reviewed-by: soumya k <skoduri at redhat.com>
    > Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>

    Once difference with the version of this change in other branches is
    that leases are not included in glusterfs-3.7. Hence there is a little
    change that drops the handling of GF_UPCALL_RECALL_LEASE.

    In addition, this backport contains commit 2775dc6410:
    > libgfapi/upcall : prepend "glfs_" to callback_arg, callback_inode_arg
    > Reviewed-on: http://review.gluster.org/14702

    Change-Id: I2b8bd5a0a82036d2abea1a217f5e5975a1d4fe93
    BUG: 1347715
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/15602
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V543S1zfr9&a=cc_unsubscribe