[Bugs] [Bug 1311407] New: glusterfs : fix double free possibility in the code

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1311407

            Bug ID: 1311407
           Summary: glusterfs : fix double free possibility in the code
           Product: GlusterFS
           Version: 3.7.9
         Component: core
          Keywords: EasyFix, Triaged
          Severity: medium
          Priority: medium
          Assignee: jthottan at redhat.com
          Reporter: jthottan at redhat.com
                CC: bugs at gluster.org
        Depends On: 1247603



+++ This bug was initially created as a clone of Bug #1247603 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-07-28 08:19:47 EDT ---

REVIEW: http://review.gluster.org/11775 (libglusterfs : assigning the pointer
to NULL after freeing it) posted (#1) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-16 04:44:42 EST ---

REVIEW: http://review.gluster.org/11775 (libglusterfs : assigning the pointer
to NULL after freeing it) posted (#2) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-22 07:01:58 EST ---

REVIEW: http://review.gluster.org/13483 (gfapi : Avoid double freeing of dict
in glfs_h_getxattrs()) posted (#1) for review on master by jiffin tony Thottan
(jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-23 05:24:06 EST ---

REVIEW: http://review.gluster.org/13483 (gfapi : Avoid double freeing of dict
in glfs_*_*getxattr) posted (#2) for review on master by jiffin tony Thottan
(jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-23 13:44:04 EST ---

COMMIT: http://review.gluster.org/13483 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit f3c48b4a729a56ad6e6d9b2ac0b08ce1ec0f3fc3
Author: Jiffin Tony Thottan <jthottan at gmail.com>
Date:   Mon Feb 22 17:20:58 2016 +0530

    gfapi : Avoid double freeing of dict in glfs_*_*getxattr

    The dict variable "xattr" is passed to glfs_getxattr_process() and
    glfs_listxattr_process() in glfs_*_*getxattrs(). This variable is
    unrefed by both functions and again in caller function which may
    result in segfault. So it is wrong to call dict_unref() in both
    glfs_*xattr_process functions.

    Change-Id: I227f55ebc3169f58910863c04ae536a8d789e80e
    BUG: 1247603
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/13483
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1247603
[Bug 1247603] glusterfs : fix double free possibility in the code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cDKeLucq9j&a=cc_unsubscribe