[Bugs] [Bug 1310970] New: Accessing program list in build_prog_details () should be lock protected

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1310970

            Bug ID: 1310970
           Summary: Accessing program list in build_prog_details () should
                    be lock protected
           Product: GlusterFS
           Version: 3.7.8
         Component: rpc
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1306560



+++ This bug was initially created as a clone of Bug #1306560 +++

Description of problem:

Currently build_prog_details() iterates over the rpcsvc's program list and
constructs a local linked list. However the same happens with out any lock
protection and hence this can cause a crash if some other writer threads modify
the same list.

Version-Release number of selected component (if applicable):
Mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-02-11 05:09:31 EST ---

REVIEW: http://review.gluster.org/13428 (rpc : build_prog_details should
iterate program list inside critical section) posted (#1) for review on master
by Atin Mukherjee (amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-11 06:45:55 EST ---

REVIEW: http://review.gluster.org/13428 (rpc : build_prog_details should
iterate program list inside critical section) posted (#2) for review on master
by Atin Mukherjee (amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-12 06:31:06 EST ---

REVIEW: http://review.gluster.org/13428 (rpc : build_prog_details should
iterate program list inside critical section) posted (#3) for review on master
by Atin Mukherjee (amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-22 05:49:33 EST ---

REVIEW: http://review.gluster.org/13428 (rpc : build_prog_details should
iterate program list inside critical section) posted (#4) for review on master
by Atin Mukherjee (amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-22 13:07:15 EST ---

COMMIT: http://review.gluster.org/13428 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 663d1a5eed5a8aef6cfad4710e16d21740bf0da8
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Feb 11 15:37:08 2016 +0530

    rpc : build_prog_details should iterate program list inside critical
section

    While I was analyzing a glusterd crash from free_prog_details, a code
    walkthrough detects that we iterate over the rpc svc program list without
been
    inside the criticial section. This opens up a possibility of a crash when
there
    is a concurrent writer updating the same list. Solution is to read the list
    inside lock.

    Change-Id: Ib4b4b0022a9535e139cd3c00574aab23f07aa9d2
    BUG: 1306560
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/13428
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1306560
[Bug 1306560] Accessing program list in build_prog_details () should be
lock protected
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.