[Bugs] [Bug 1308800] New: access-control : spurious error log message on every setxattr call

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1308800

            Bug ID: 1308800
           Summary: access-control : spurious error log message on every
                    setxattr call
           Product: GlusterFS
           Version: 3.7.7
         Component: access-control
          Keywords: EasyFix, Triaged
          Severity: medium
          Priority: medium
          Assignee: jthottan at redhat.com
          Reporter: jthottan at redhat.com
                CC: bugs at gluster.org
        Depends On: 1303501
            Blocks: 1304350



+++ This bug was initially created as a clone of Bug #1303501 +++

Description of problem:

Spurious log message is filled in gluster logs on every setxattr call. This is
due to a check is missed before calling the handling_other_acl_related_xattr()
in
posix_acl_setxattr_cbk()

Version-Release number of selected component (if applicable):
mainline


Additional info 

log message :
[2016-01-31 17:38:48.027792] I [dict.c:473:dict_get]
(-->/usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so(posix_acl_setxattr_cbk+0x26)
[0x7f2334c5c166]
-->/usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so(handling_other_acl_related_xattr+0xb0)
[0x7f2334c5c0f0] -->/usr/lib/x86_64-linux-gnu/libglusterfs.so.0(dict_get+0x93)
[0x7f233c04b0c3] ) 0-dict: !this || key=system.posix_acl_default [Invalid
argument]

--- Additional comment from Vijay Bellur on 2016-02-01 00:45:24 EST ---

REVIEW: http://review.gluster.org/13325 (access-control : remove spurious error
message from the posix_setxattr_cbk) posted (#1) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-08 01:48:52 EST ---

REVIEW: http://review.gluster.org/13325 (access-control : remove spurious error
message from the posix_setxattr_cbk) posted (#2) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-09 09:33:43 EST ---

COMMIT: http://review.gluster.org/13325 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit b72172f4516ff5627f15168213a54b171463803f
Author: Jiffin Tony Thottan <jthottan at gmail.com>
Date:   Mon Feb 1 11:02:37 2016 +0530

    access-control : remove spurious error message from the posix_setxattr_cbk

    A check for dictionary is required before calling
handling_other_acl_related_xattr()
    in posix_setxattr_cbk(). Otherwise following message will be poped up on
every settxattr
    call.

    [2016-01-31 17:38:48.027792] I [dict.c:473:dict_get]
     (-->/usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so
    (posix_acl_setxattr_cbk+0x26) [0x7f2334c5c166] -->
    /usr/lib/x86_64-linux-gnu/glusterfs/3.7.6/xlator/system/posix-acl.so
    (handling_other_acl_related_xattr+0xb0) [0x7f2334c5c0f0]
    -->/usr/lib/x86_64-linux-gnu/libglusterfs.so.0(dict_get+0x93)
    [0x7f233c04b0c3] ) 0-dict: !this ||
    key=system.posix_acl_default [Invalid argument]

    Change-Id: I93f7e0f764c94dce38bdde95a68341f69a52122d
    BUG: 1303501
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/13325
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1303501
[Bug 1303501] access-control : spurious error log message on every setxattr
call
https://bugzilla.redhat.com/show_bug.cgi?id=1304350
[Bug 1304350] access-control : spurious error log message on every setxattr
call
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=edPBKxZcHx&a=cc_unsubscribe