[Bugs] [Bug 1303995] SMB: SMB crashes with AIO enabled on reads + vers=3.0

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 11 05:46:33 UTC 2016


--- Comment #11 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13340 committed in master by Shyamsundar
Ranganathan (srangana at redhat.com) 
commit 88d772c05c45c467bfccebfc51f6a0e0ea9ca287
Author: Rajesh Joseph <rjoseph at redhat.com>
Date:   Tue Feb 2 04:22:04 2016 +0530

    libgfapi: glfd close is not correctly handled for async fop

    There is chance that before the async fop is complete client can send
    a close. libgfapi destroys glfd on close. Therefore it can lead to
    crash or unexpected behaviour when the pening fop reaches libgfapi
    layer. Currently we don't provide any api to cancel these outstanding
    fops neither we check if the glfd is already closed or not.

    Therefore as a fix provided refcount for glfd. Each fop (sync or async)
    will take a ref and once the fop is complete it will unref the refcount.
    We should not call the registered callback function if glfd is already
    closed. To achieve this we maintain state of glfd so that we can safely
    take a call if the fd is closed or not.

    Change-Id: Ibe71b2225312db3f1be66b244fcf8826c70c357d
    BUG: 1303995
    Signed-off-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-on: http://review.gluster.org/13340
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the Bugs mailing list