[Bugs] [Bug 1371947] New: Track the client that performed readdirp

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1371947

            Bug ID: 1371947
           Summary: Track the client that performed readdirp
           Product: GlusterFS
           Version: 3.8.3
         Component: upcall
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org, pgurusid at redhat.com,
                    skoduri at redhat.com
        Depends On: 1369430



+++ This bug was initially created as a clone of Bug #1369430 +++

Description of problem:
Currently when a client does a readdirp on directory say dir1 (containing f1
file), only the fact that client accessed dir1 is stored in upcall, but it
sould also store that f1 was also accessed by that client. If not this may lead
to stale cache on client side, when client caches the readdirp data alone. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-08-25 06:43:57 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir) posted (#1) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-25 07:24:15 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir) posted (#2) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-25 12:41:19 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir) posted (#3) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-25 13:30:52 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir entries) posted (#4) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-26 06:05:55 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir entries) posted (#5) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-27 08:15:53 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir entries) posted (#6) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-30 07:20:24 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir entries) posted (#7) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-30 07:20:44 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
even on readdir entries) posted (#8) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-30 13:28:39 CEST ---

REVIEW: http://review.gluster.org/15313 (upcall: Mark the clients as accessed
on readdirp entries) posted (#9) for review on master by Poornima G
(pgurusid at redhat.com)

--- Additional comment from Worker Ant on 2016-08-31 15:44:06 CEST ---

COMMIT: http://review.gluster.org/15313 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 9d8bbbb8f68a0c45bfbb2e891cdbd9b9a1121259
Author: Poornima G <pgurusid at redhat.com>
Date:   Thu Aug 25 10:09:20 2016 +0530

    upcall: Mark the clients as accessed on readdirp entries

    Currently when a client performs a readdirp it is not stored
    in upcall, as one of the clients that have accessed the files.
    Hence, when any other client modifies the file, the client that
    had performed readdirp will not get any notifications.

    Fix this by adding the clients to upcall database when they
    perform readdirp.

    Change-Id: I7767f1e26bf1bd1f67702a6d01f8aa64526ccc46
    BUG: 1369430
    Signed-off-by: Poornima G <pgurusid at redhat.com>
    Reviewed-on: http://review.gluster.org/15313
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: soumya k <skoduri at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1369430
[Bug 1369430] Track the client that performed readdirp
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.