[Bugs] [Bug 1368841] Applications not calling glfs_h_poll_upcall() have upcall events cached for no use

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1368841



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15346 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com) 
------
commit 3eecd4e2b5a923d7a5da1b899b6f0009e319b98d
Author: Niels de Vos <ndevos at redhat.com>
Date:   Tue Aug 30 10:23:55 2016 +0200

    gfapi: do not cache upcalls if the application is not interested

    When the volume option 'features.cache-invalidation' is enabled, upcall
    events are sent from the brick process to the client. Even if the client
    is not interested in upcall events itself, md-cache or other xlators may
    benefit from them.

    By adding a new 'cache_upcalls' boolean in the 'struct glfs', we can
    enable the caching of upcalls when the application called
    glfs_h_poll_upcall(). NFS-Ganesha sets up a thread for handling upcalls
    in the initialization phase, and calls glfs_h_poll_upcall() before any
    NFS-client accesses the NFS-export.

    In the future there will be a more flexible registration API for
    enabling certain kind of upcall events. Until that is available, this
    should work just fine.

    Verificatio of this change is not trivial within our current regression
    test framework. The bug report contains a description on how to reliably
    reproduce the problem with the glusterfs-coreutils.

    Cherry picked from commit 218c9b033fa44eacbc27d87491abd830548b362e:
    > Change-Id: I818595c92db50e6e48f7bfe287ee05103a4a30a2
    > BUG: 1368842
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-on: http://review.gluster.org/15191
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Poornima G <pgurusid at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: soumya k <skoduri at redhat.com>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

    Change-Id: I818595c92db50e6e48f7bfe287ee05103a4a30a2
    BUG: 1368841
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/15346
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: soumya k <skoduri at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p0Aw9k35b9&a=cc_unsubscribe