[Bugs] [Bug 1211863] RFE: Support in md-cache to use upcall notifications to invalidate its cache

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 27 12:56:38 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1211863



--- Comment #95 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15045 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit f8b51bef8820142264bdca9cfe0d7106fb045c2a
Author: Poornima G <pgurusid at redhat.com>
Date:   Fri Jul 29 15:03:47 2016 +0530

    md-cache: Fix wrong cache time update for xattrs

    In md-cache, the cache has two times:
    1. Time when the stat was last fetched for that inode
    2. Time when the xattrs were last fetched for that inode. This
    time should not be updated when only one of the xattrs is updated.
    If, its updated when one of the cached xattr is changed, it can so
    happen that the other xattrs have past their cache timeout, but are
    still served from cache.

    Solution:
    Do not update the xattr cache time, when one of the xattrs being cached
    is changed. With this, we may end up in cache timeout though it was
    updated recently, but it is not a harm. The other way is to have
    timeout for every xattr that is being cached. Its more complicated, and
    may be not worth it, as we have lot of lookup fops, that are overloaded to
    get all the xattrs.

    Change-Id: Id77e547f403fc792348f1ea56b468b9260a5a34f
    BUG: 1211863
    Signed-off-by: Poornima G <pgurusid at redhat.com>
    Reviewed-on: http://review.gluster.org/15045
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FA51HOWAbP&a=cc_unsubscribe


More information about the Bugs mailing list