[Bugs] [Bug 1370172] New: protocol/server: readlink rsp xdr failed while readlink got an error

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1370172

            Bug ID: 1370172
           Summary: protocol/server: readlink rsp xdr failed  while
                    readlink got an error
           Product: GlusterFS
           Version: 3.8.3
         Component: protocol
          Keywords: Triaged
          Assignee: ryan.ding at open-fs.com
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org
        Depends On: 1369530



+++ This bug was initially created as a clone of Bug #1369530 +++

Description of problem:

in function server_readlink_cbk, if readlink got a file system error (like
ENOENT, etc.), rsp.path will leave to be NULL. and this will lead a xdr error
in xdr_gfs3_readlink_rsp. original errno is lost.

--- Additional comment from Worker Ant on 2016-08-23 18:44:11 CEST ---

REVIEW: http://review.gluster.org/15299 (protocol/server: readlink rsp xdr will
fail while readlink got an error) posted (#1) for review on master by Anonymous
Coward

--- Additional comment from Worker Ant on 2016-08-25 04:06:28 CEST ---

COMMIT: http://review.gluster.org/15299 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit c70f4b3af619bcdd08d57147a4ed582bdad98084
Author: Ryan Ding <ryan.ding at open-fs.com>
Date:   Wed Aug 24 00:41:13 2016 +0800

    protocol/server: readlink rsp xdr will fail while readlink got an error

    set gfs3_readlink_rsp.path with an empty string while error happen, to
    make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
    lost, and return an rpc internal errno instead.

    Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
    BUG: 1369530
    Signed-off-by: Ryan Ding <ryan.ding at open-fs.com>
    Reviewed-on: http://review.gluster.org/15299
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

--- Additional comment from Worker Ant on 2016-08-25 05:23:49 CEST ---

REVIEW: http://review.gluster.org/15312 (protocol/server: readlink rsp xdr will
fail while readlink got an error) posted (#1) for review on release-3.8 by Ryan
Ding (ryan.ding at open-fs.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1369530
[Bug 1369530] protocol/server: readlink rsp xdr failed  while readlink got
an error
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jeVjSubBXm&a=cc_unsubscribe