[Bugs] [Bug 1369211] New: fix bug in protocol/client lookup callback

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1369211

            Bug ID: 1369211
           Summary: fix bug in protocol/client lookup callback
           Product: GlusterFS
           Version: 3.7.14
         Component: protocol
          Assignee: bugs at gluster.org
          Reporter: atalur at redhat.com
                CC: bugs at gluster.org
        Depends On: 1366284
            Blocks: 1211863, 1369187



+++ This bug was initially created as a clone of Bug #1366284 +++

Description of problem:
in client3_3_lookup_cbk xdata is not passed to the upper xlators on failure.
But there could be other xlators (like afr) that expect xdata to be present
even on 
failure.
Fix it.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-08-11 09:53:02 EDT ---

REVIEW: http://review.gluster.org/15120 (protocol/client: Unserialize xdata
even if lookup fails) posted (#2) for review on master by Anuradha Talur
(atalur at redhat.com)

--- Additional comment from Vijay Bellur on 2016-08-12 03:11:51 EDT ---

REVIEW: http://review.gluster.org/15120 (protocol/client: Unserialize xdata
even if lookup fails) posted (#3) for review on master by Anuradha Talur
(atalur at redhat.com)

--- Additional comment from Vijay Bellur on 2016-08-16 06:49:47 EDT ---

REVIEW: http://review.gluster.org/15178 (afr: set data and metadata readable to
child up when no heal needed) posted (#1) for review on master by Anuradha
Talur (atalur at redhat.com)

--- Additional comment from Vijay Bellur on 2016-08-17 06:26:08 EDT ---

COMMIT: http://review.gluster.org/15120 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 59186114f9545fda529368ee26c3cd3d88a80751
Author: Anuradha Talur <atalur at redhat.com>
Date:   Tue Aug 9 21:09:11 2016 +0530

    protocol/client: Unserialize xdata even if lookup fails

    Problem:
    AFR relies on xdata returned by lookup to determine if
    there are any files that need healing. This info is further
    used to optimize readdirp.

    In case of lookups with negative return value, client
    xlator was sending NULL xdata. Due to absence of xdata,
    AFR conservatively assumes that there are files that
    need healing, which is incorrect.

    Solution:
    Even in case of unsuccessful lookups, send the xdata received
    by protocol client so that higher xlators can get the info
    that they rely on.

    Change-Id: Id3a1023eb536180888eb2c0b39050000b76f7226
    BUG: 1366284
    Signed-off-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-on: http://review.gluster.org/15120
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Poornima G <pgurusid at redhat.com>
    Tested-by: Poornima G <pgurusid at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Ashish Pandey <aspandey at redhat.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1211863
[Bug 1211863] RFE: Support in md-cache to use upcall notifications to
invalidate its cache
https://bugzilla.redhat.com/show_bug.cgi?id=1366284
[Bug 1366284] fix bug in protocol/client lookup callback
https://bugzilla.redhat.com/show_bug.cgi?id=1369187
[Bug 1369187] fix bug in protocol/client lookup callback
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.