[Bugs] [Bug 1366494] Rebalance is not considering the brick sizes while fixing the layout

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 16 13:00:27 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1366494



--- Comment #2 from Jeff Darcy <jdarcy at redhat.com> ---
Nithya's analysis is correct.  We generate a new layout based on brick sizes,
then attempt to optimize it for maximum overlap with the current layout.  That
optimization is important to minimize data movement, but unfortunately it's
broken in this case because it doesn't account properly for where each range
already resides.  I wrote that function BTW, so it's my fault.  For now, we
should probably just disable the optimization phase when we're weighting by
brick size.  Longer term, what we need to do is fix
dht_selfheal_layout_maximize_overlap.  There's a place where it tries to
determine whether a particular swap would be an improvement or not.  That
particular calculation needs to be enhance to account for the *actual* current
and proposed locations for a range, instead of (effectively) inferring those
locations from ordinal positions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i0pMHQ0hVF&a=cc_unsubscribe


More information about the Bugs mailing list