[Bugs] [Bug 1310970] Accessing program list in build_prog_details () should be lock protected

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1310970



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13488 committed in release-3.7 by Kaushal M
(kaushal at redhat.com) 
------
commit 42b5b9bc63891a3447db56224713c5b1028549c5
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Feb 11 15:37:08 2016 +0530

    rpc : build_prog_details should iterate program list inside critical
section

    Backport of http://review.gluster.org/13428

    While I was analyzing a glusterd crash from free_prog_details, a code
    walkthrough detects that we iterate over the rpc svc program list without
been
    inside the criticial section. This opens up a possibility of a crash when
there
    is a concurrent writer updating the same list. Solution is to read the list
    inside lock.

    > Reviewed-on: http://review.gluster.org/13428
    > Smoke: Gluster Build System <jenkins at build.gluster.com>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

    BUG: 1310970
    Change-Id: Ib4b4b0022a9535e139cd3c00574aab23f07aa9d2
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Signed-off-by: Oleksandr Natalenko <oleksandr at natalenko.name>
    Reviewed-on: http://review.gluster.org/13488
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XK5tP6Zx52&a=cc_unsubscribe