[Bugs] [Bug 1365869] gfapi: use const qualifier for glfs_*timens()

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 12 11:20:07 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1365869



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/15137 committed in release-3.7 by Kaleb
KEITHLEY (kkeithle at redhat.com) 
------
commit 429d587114f1598774c1d3def064ea4f6415521b
Author: Oleksandr Natalenko <oleksandr at natalenko.name>
Date:   Tue Aug 9 14:58:08 2016 +0300

    gfapi: use const qualifier for glfs_*timens()

    glfs_*timens() functions have the last argument
    of struct timespec type that is supposed to be
    const. Now using glfs_*timens() in fops, implemented
    on top of FUSE library, leads to compiler-time warning
    about discarding const qualifier.

    Introducing const qualifier does not break ABI,
    so let's just fix it.

    > Reviewed-on: http://review.gluster.org/15119
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>

    BUG: 1365869
    Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800
    Signed-off-by: Oleksandr Natalenko <oleksandr at natalenko.name>
    Reviewed-on: http://review.gluster.org/15137
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list