[Bugs] [Bug 1354499] service file is executable

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1354499



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/15115 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com) 
------
commit 7ba61c46164114d6cfd606a098b45aaf3eaa8773
Author: Niels de Vos <ndevos at redhat.com>
Date:   Tue Jul 19 12:55:03 2016 +0200

    build: systemd unit should not be marked executable

    systemd complains about the unit for GlusterD when it is executable:

      Configuration file /usr/lib/systemd/system/glusterd.service is marked
executable. Please remove executable permission bits. Proceeding anyway.

    The Makefile that installs the unit has some scripted commands. These
    are not needed and standard "*dir" and "*DATA" postfixes for variables
    can be used instead.

    The EXTRA_DIST variable is needed for building the 'make dist' tarball
    on systems where there is no systemd. The unit would be missing from the
    tarball if it is not explicitly included.

    Cherry picked from commit 9f22282795e20fd62b22847b92dffd0cde9cca1b:
    > BUG: 1354489
    > Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
    > Reported-by: Sergej Pupykin <ml at sergej.pp.ru>
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-on: http://review.gluster.org/14892
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

    Change-Id: I5e72ec201036906b9b2458bc8931ccebf9a8c6b4
    BUG: 1354499
    Reported-by: Sergej Pupykin <ml at sergej.pp.ru>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/15115
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hr55myVkrl&a=cc_unsubscribe