[Bugs] [Bug 1364497] posix: honour fsync flags in posix_do_zerofill

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 6 05:40:28 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1364497



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/15103 committed in release-3.8 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit 2c748b731f233588b97d375ce92a5ae56612d764
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Aug 5 11:22:18 2016 +0000

    posix: honour fsync flags in posix_do_zerofill

    Backport of http://review.gluster.org/#/c/15100/
    commit fe1054110ac54750ca0333a727d83b14a98e165e introduced fallocate +
    FALLOC_FL_ZERO_RANGE to do posix_do_zerofill but did not do an fsync if
    O_SYNC or O_DSYNC fd flags were set. Prashant Pai pointed out performing
    fallocate(2) does not remove the necessity to do fsyncs if durability is
    desired:
http://linux-fsdevel.vger.kernel.narkive.com/bDmrAUlh/fallocate-falloc-fl-punch-hole

    So fixed it to honour the fd flags.

    Change-Id: I27ae90b429185d0af29a5e632c4a8b242075a899
    BUG: 1364497
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    (cherry picked from commit cf51bc699646359be92969024a52c225e7ee55a1)
    Reviewed-on: http://review.gluster.org/15103
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BuF5zaf4jA&a=cc_unsubscribe


More information about the Bugs mailing list