[Bugs] [Bug 1221623] glusterd: add brick command should re-use the port for listening which is freed by remove-brick.
bugzilla at redhat.com
bugzilla at redhat.com
Thu Aug 4 04:43:38 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1221623
--- Comment #33 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/15005 committed in master by Atin Mukherjee
(amukherj at redhat.com)
------
commit c3dee6d35326c6495591eb5bbf7f52f64031e2c4
Author: Atin Mukherjee <amukherj at redhat.com>
Date: Mon Jul 25 19:09:08 2016 +0530
glusterd: clean up old port and allocate new one on every restart
GlusterD as of now was blindly assuming that the brick port which was
already
allocated would be available to be reused and that assumption is absolutely
wrong.
Solution : On first attempt, we thought GlusterD should check if the
already
allocated brick ports are free, if not allocate new port and pass it to the
daemon. But with that approach there is a possibility that if PMAP_SIGNOUT
is
missed out, the stale port will be given back to the clients where
connection
will keep on failing. Now given the port allocation always start from
base_port,
if everytime a new port has to be allocated for the daemons, the port range
will
still be under control. So this fix tries to clean up old port using
pmap_registry_remove () if any and then goes for pmap_registry_alloc ()
Change-Id: If54a055d01ab0cbc06589dc1191d8fc52eb2c84f
BUG: 1221623
Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
Reviewed-on: http://review.gluster.org/15005
Smoke: Gluster Build System <jenkins at build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: Avra Sengupta <asengupt at redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GplZA6JuzB&a=cc_unsubscribe
More information about the Bugs
mailing list