[Bugs] [Bug 1311407] glusterfs : fix double free possibility in the code

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 3 11:25:00 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1311407



--- Comment #5 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13505 committed in release-3.7 by Niels de
Vos (ndevos at redhat.com) 
------
commit 102b565fd867b7ef721b481aeb6c8c39d904ecec
Author: Jiffin Tony Thottan <jthottan at gmail.com>
Date:   Mon Feb 22 17:20:58 2016 +0530

    gfapi : Avoid double freeing of dict in glfs_*_*getxattr

    The dict variable "xattr" is passed to glfs_getxattr_process() and
    glfs_listxattr_process() in glfs_*_*getxattrs(). This variable is
    unrefed by both functions and again in caller function which may
    result in segfault. So it is wrong to call dict_unref() in both
    glfs_*xattr_process functions.

    Backport reference :
    >Change-Id: I227f55ebc3169f58910863c04ae536a8d789e80e
    >BUG: 1247603 Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    >Reviewed-on: http://review.gluster.org/13483
    >Smoke: Gluster Build System <jenkins at build.gluster.com>
    >NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    >CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    >Reviewed-by: Niels de Vos <ndevos at redhat.com>

    Change-Id: I2e574ff4b7a095749540bdb9d3593bc1d6275e56
    BUG: 1311407
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Signed-off-by: Oleksandr Natalenko <oleksandr at natalenko.name>
    Reviewed-on: http://review.gluster.org/13505
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wton6LhgE4&a=cc_unsubscribe


More information about the Bugs mailing list