[Bugs] [Bug 1266882] New: RFE: posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY' implementation

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1266882

            Bug ID: 1266882
           Summary: RFE: posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY'
                    implementation
           Product: GlusterFS
           Version: 3.7.5
         Component: quota
          Assignee: bugs at gluster.org
          Reporter: vmallika at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1243946



+++ This bug was initially created as a clone of Bug #1243946 +++

implementation of xattrop type
GF_XATTROP_ADD_DEF_ARRAY
GF_XATTROP_ADD_DEF_ARRAY64

These operations are similar to 'GF_XATTROP_ADD_ARRAY',
except that it adds a default value if xattr is missing
or its value is zero on disk.

One use-case of this operation is in inode-quota.
When a new directory is created, its default dir_count
should be set to 1. So when a xattrop performed setting
inode-xattrs, it should account initial dir_count
1 if the xattrs are not present

Here is the usage of this operation

value required in xdata for each key 
struct array {
    int32_t   newvalue_1;
    int32_t   default_1;
    int32_t   newvalue_2;
    int32_t   default_2;
    ... 
    int32_t   newvalue_n;
    int32_t   default_n;
};

xattrop GF_XATTROP_ADD_ARRAY
for i from 1 to n
{
    if (xattr (dest_i) is zero or not set in the disk)
        dest_i = dest_i + newvalue_i + default_i
    else
        dest_i = dest_i + newvalue_i
}

value in xdata after xattrop is successful
struct array {
    int32_t   dest_1;
    int32_t   dest_2;
    ...
    int32_t   dest_n;
};

--- Additional comment from Anand Avati on 2015-07-16 12:31:07 EDT ---

REVIEW: http://review.gluster.org/11702 (posix: xattrop
'GF_XATTROP_ADD_DEF_ARRAY' implementation) posted (#1) for review on master by
Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-07-16 12:36:30 EDT ---

REVIEW: http://review.gluster.org/11702 (posix: xattrop
'GF_XATTROP_ADD_DEF_ARRAY' implementation) posted (#2) for review on master by
Vijaikumar Mallikarjuna (vmallika at redhat.com)

--- Additional comment from Anand Avati on 2015-08-20 05:53:34 EDT ---

REVIEW: http://review.gluster.org/11702 (posix: xattrop
'GF_XATTROP_ADD_ARRAY_WITH_DEFAULT' implementation) posted (#3) for review on
master by Vijaikumar Mallikarjuna (vmallika at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243946
[Bug 1243946] RFE: posix: xattrop 'GF_XATTROP_ADD_DEF_ARRAY' implementation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.