[Bugs] [Bug 1262335] New: Fix invalid logic in tier.t

Fri Sep 11 12:42:41 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1262335

            Bug ID: 1262335
           Summary: Fix invalid logic in tier.t
           Product: GlusterFS
           Version: 3.7.5
         Component: tiering
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: dlambrig at redhat.com
        QA Contact: bugs at gluster.org
                CC: amukherj at redhat.com, bugs at gluster.org,
                    josferna at redhat.com
        Depends On: 1231268
            Blocks: 1244290, 1252903

+++ This bug was initially created as a clone of Bug #1231268 +++

The tier.t logic did not properly check for corrupted data after migration.

--- Additional comment from Anand Avati on 2015-06-17 11:15:57 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#1) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-06-22 10:48:19 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#2) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-06-22 13:56:08 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#3) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-06-26 19:25:40 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#4) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-06-29 11:32:15 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#5) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-06-29 11:45:30 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in
tier.t) posted (#6) for review on master by Pamela Ousley (pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-07-07 15:45:36 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical
bugs/timing errors in tier.t) posted (#7) for review on master by Pamela Ousley
(pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-07-07 15:58:14 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical
bugs/timing errors in tier.t) posted (#8) for review on master by Pamela Ousley
(pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-07-13 13:14:56 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical
bugs/timing errors in tier.t) posted (#9) for review on master by Pamela Ousley
(pousley at redhat.com)

--- Additional comment from Anand Avati on 2015-07-13 17:12:30 EDT ---

COMMIT: http://review.gluster.org/11285 committed in master by Dan Lambright
(dlambrig at redhat.com) 
------
commit f7b9379a0a03fb1d2df56bbfc8dca06f5f3b8437
Author: Pamela Ousley <pousley at redhat.com>
Date:   Wed Jun 17 15:07:55 2015 -0400

    cluster/tier : fix for logical bugs/timing errors in tier.t

    The md5sum fingerprints were not correctly compared after moving
    files between the hot and cold tiers.

    This version of tier.t uses a new function, "check_counters", to
    ensure that the number of promotions/demotions is as expected.
    This is intended to avoid spurious timing-related errors that were
    seen with the old script.

    Change-Id: I4a0ae7315493bfd307a0f68f21fa3ea33c88b08f
    BUG: 1231268
    Signed-off-by: Pamela Ousley <pousley at redhat.com>
    Reviewed-on: http://review.gluster.org/11285
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>

--- Additional comment from Anand Avati on 2015-08-11 15:38:21 EDT ---

REVIEW: http://review.gluster.org/11885 (cluster/tier: fix 64 bit issue with
sql query using times) posted (#1) for review on master by Dan Lambright
(dlambrig at redhat.com)

--- Additional comment from Anand Avati on 2015-08-13 07:38:59 EDT ---

COMMIT: http://review.gluster.org/11885 committed in master by Dan Lambright
(dlambrig at redhat.com) 
------
commit 6e055b7d7355cadbbf559ad4bed23872aa1743df
Author: Dan Lambright <dlambrig at redhat.com>
Date:   Tue Aug 11 15:36:26 2015 -0400

    cluster/tier: fix 64 bit issue with sql query using times

    We overflowed when converting seconds to usecs in preperation for
    sql queries. The fix uses uint64_t throughout including subexpressions.

    Change-Id: I59bdb742197400dede97f54735b52030920b0d19
    BUG: 1231268
    Signed-off-by: Dan Lambright <dlambrig at redhat.com>
    Reviewed-on: http://review.gluster.org/11885
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Joseph Fernandes

--- Additional comment from Anand Avati on 2015-08-13 14:46:34 EDT ---

REVIEW: http://review.gluster.org/11914 (cluster/tier: add detach tier test)
posted (#1) for review on master by Dan Lambright (dlambrig at redhat.com)

--- Additional comment from Anand Avati on 2015-08-14 10:05:33 EDT ---

REVIEW: http://review.gluster.org/11914 (cluster/tier: add detach tier test)
posted (#2) for review on master by Dan Lambright (dlambrig at redhat.com)

--- Additional comment from Dan Lambright on 2015-08-25 01:15:35 EDT ---

--- Additional comment from Dan Lambright on 2015-08-25 01:18:42 EDT ---

There is still a problem with test 29, intermittent failures when the database
is locked and another process tries to get a lock. When the second fails to get
the lock the promote/demotion fails and this aborts the operation; the counter
is never raised; the test fails.

--- Additional comment from Vijay Bellur on 2015-09-08 12:28:49 EDT ---

REVIEW: http://review.gluster.org/12128 (gluster/tier Remove tier.t from
spurious failure list) posted (#1) for review on master by Dan Lambright
(dlambrig at redhat.com)

--- Additional comment from Vijay Bellur on 2015-09-09 18:46:21 EDT ---

COMMIT: http://review.gluster.org/12128 committed in master by Dan Lambright
(dlambrig at redhat.com) 
------
commit 3a6e397bccf7ebaf9528617f5615553670211edf
Author: Dan Lambright <dlambrig at redhat.com>
Date:   Tue Sep 8 12:26:47 2015 -0400

    gluster/tier Remove tier.t from spurious failure list

    The spurious failure was related to database lock contention,
    and was fixed in patch 12031.

    Ran tier.t in loop (very many) times successfully to confirm fixed.

    Change-Id: Ib7446bcd02c76dea03b4cf273aae0dba27c4ef19
    BUG: 1231268
    Signed-off-by: Dan Lambright <dlambrig at redhat.com>
    Reviewed-on: http://review.gluster.org/12128
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

--- Additional comment from Vijay Bellur on 2015-09-09 18:48:02 EDT ---

REVIEW: http://review.gluster.org/11914 (cluster/tier: add detach tier test)
posted (#3) for review on master by Dan Lambright (dlambrig at redhat.com)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1231268
[Bug 1231268] Fix invalid logic in tier.t
https://bugzilla.redhat.com/show_bug.cgi?id=1244290
[Bug 1244290] Fix invalid logic in tier.t
https://bugzilla.redhat.com/show_bug.cgi?id=1252903
[Bug 1252903] Fix invalid logic in tier.t
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.