[Bugs] [Bug 1259694] New: Data Tiering:Regression:Commit of detach tier passes without directly without even issuing a detach tier start

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1259694

            Bug ID: 1259694
           Summary: Data Tiering:Regression:Commit of detach tier passes
                    without directly without even issuing a detach tier
                    start
           Product: GlusterFS
           Version: 3.7.4
         Component: tiering
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: nchilaka at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org



Description of problem:
======================
Detach tier commit should not pass if there was no detach tier start triggered.
That should work only if force option is used clearly.
However, detach tier commit is passing even without detach tier start is
triggered, which was not the case previously.
This is a regression.


[root at nag-manual-node1 /]# gluster v info vvs;gluster v status vvs

Volume Name: vvs
Type: Tier
Volume ID: 988d395c-be78-4d84-939b-eaad367f3504
Status: Started
Number of Bricks: 6
Transport-type: tcp
Hot Tier :
Hot Tier Type : Distribute
Number of Bricks: 2
Brick1: 10.70.46.36:/rhs/brick4/vvs1
Brick2: 10.70.46.84:/rhs/brick4/vvs1
Cold Tier:
Cold Tier Type : Distribute
Number of Bricks: 4
Brick3: 10.70.46.84:/rhs/brick1/vvs
Brick4: 10.70.46.36:/rhs/brick1/vvs
Brick5: 10.70.46.84:/rhs/brick2/vvs
Brick6: 10.70.46.36:/rhs/brick2/vvs
Options Reconfigured:
performance.readdir-ahead: on
Status of volume: vvs
Gluster process                             TCP Port  RDMA Port  Online  Pid
------------------------------------------------------------------------------
Hot Bricks:
Brick 10.70.46.36:/rhs/brick4/vvs1          49156     0          Y       15202
Brick 10.70.46.84:/rhs/brick4/vvs1          49156     0          Y       24052
Cold Bricks:
Brick 10.70.46.84:/rhs/brick1/vvs           49152     0          Y       23722
Brick 10.70.46.36:/rhs/brick1/vvs           49152     0          Y       14985
Brick 10.70.46.84:/rhs/brick2/vvs           49153     0          Y       23740
Brick 10.70.46.36:/rhs/brick2/vvs           49153     0          Y       15003
NFS Server on localhost                     2049      0          Y       24071
NFS Server on 10.70.46.36                   2049      0          Y       15221

Task Status of Volume vvs
------------------------------------------------------------------------------
Task                 : Rebalance           
ID                   : 034a03d3-f977-4a59-9c55-4a7d9cd429e8
Status               : in progress         

[root at nag-manual-node1 /]# gluster v detach-tier vvs commit
volume detach-tier commit: success
Check the detached bricks to ensure all files are migrated.
If files with data are found on the brick path, copy them via a gluster mount
point before re-purposing the removed brick. 
[root at nag-manual-node1 /]# gluster v info vvs

Volume Name: vvs
Type: Distribute
Volume ID: 988d395c-be78-4d84-939b-eaad367f3504
Status: Started
Number of Bricks: 4
Transport-type: tcp
Bricks:
Brick1: 10.70.46.84:/rhs/brick1/vvs
Brick2: 10.70.46.36:/rhs/brick1/vvs
Brick3: 10.70.46.84:/rhs/brick2/vvs
Brick4: 10.70.46.36:/rhs/brick2/vvs
Options Reconfigured:
performance.readdir-ahead: on
[root at nag-manual-node1 /]# 


Version-Release number of selected component (if applicable):
================================================================
[root at nag-manual-node1 /]# rpm -qa|grep gluster
glusterfs-libs-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-api-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-client-xlators-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-fuse-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-cli-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-3.7.4-0.16.git9f27ef9.el6.x86_64
glusterfs-server-3.7.4-0.16.git9f27ef9.el6.x86_64
[root at nag-manual-node1 /]# gluster --version
glusterfs 3.7.4 built on Sep  2 2015 18:06:07
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General
Public License.


How reproducible:
===================
everytime easily

Steps to Reproduce:
====================
1.create a volume, start it and attac tier to vol 
2.now issue a detach-tier <vname> commit 



Actual results:
================
commit detaches tier without even requiring a detach tier start

Expected results:
=================
commit should be allowed only after detach tier start is triggered




It was working previously. hence  a regression

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.