[Bugs] [Bug 1258769] New: libglusterfs: Pending - Porting log messages to new framework

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1258769

            Bug ID: 1258769
           Summary: libglusterfs: Pending - Porting log messages to new
                    framework
           Product: GlusterFS
           Version: 3.7.3
         Component: logging
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: mliyazud at redhat.com
                CC: annair at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, mliyazud at redhat.com,
                    sasundar at redhat.com
        Depends On: 1242211, 1252836
            Blocks: 1241957



+++ This bug was initially created as a clone of Bug #1252836 +++

+++ This bug was initially created as a clone of Bug #1242211 +++

Description of problem:
-----------------------
There are few instances of 'gf_log' and 'gf_log_callingfn' seen under
libglusterfs
These instances needs to be ported to new logging framework

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS-3.1 Nightly ( glusterfs-3.7.1-8.el6rhs )


Expected results:
-----------------
All old log messages should be ported to new logging framework

--- Additional comment from SATHEESARAN on 2015-07-12 13:18:07 EDT ---

src/inode.c:  gf_log_callingfn (THIS->name, GF_LOG_WARNING,
src/inode.c-        "inode not found");

[satheesaran at dhcppc1 libglusterfs]$ grep -r "gf_log " src/logging.h -B1 -A1

int _gf_log (const char *domain, const char *file,
             const char *function, int32_t line, gf_loglevel_t level,
--
                FMT_WARN (fmt);                                         \
                _gf_log (dom, __FILE__, __FUNCTION__, __LINE__,         \
                         levl, ##fmt);                                  \
--
#define GF_LOG_OCCASIONALLY(var, args...) if (!(var++%GF_UNIVERSAL_ANSWER)) { \
                gf_log (args);                                          \
        }
--
#define GF_DEBUG(xl, format, args...)                           \
        gf_log ((xl)->name, GF_LOG_DEBUG, format, ##args)
#define GF_INFO(xl, format, args...)                            \
        gf_log ((xl)->name, GF_LOG_INFO, format, ##args)
#define GF_WARNING(xl, format, args...)                         \
        gf_log ((xl)->name, GF_LOG_WARNING, format, ##args)
#define GF_ERROR(xl, format, args...)                           \
        gf_log ((xl)->name, GF_LOG_ERROR, format, ##args)


--
src/xlator.c:  gf_log ("glusterfs", gf_log_get_loglevel(),
src/xlator.c-       "setting log level to %d (old-value=%d)",
--
src/xlator.c:  gf_log (this->name, gf_log_get_xl_loglevel (this),
src/xlator.c-        "setting log level to %d (old-value=%d)",
--
src/xlator.c:  gf_log (trav->name, gf_log_get_xl_loglevel (trav),
src/xlator.c-        "setting log level to %d (old-value=%d)",

src/unittest/log_mock.c:int _gf_log (const char *domain, const char *file,
src/unittest/log_mock.c-             const char *function, int32_t line,
gf_loglevel_t level,

--
src/run.c:  gf_log_callingfn (dom, lvl, "%s: %s", msg, buf);
src/run.c-
--
src/timespec.c:        gf_log_callingfn ("timer", GF_LOG_TRACE,
"%"GF_PRI_TIME".%09"GF_PRI_TIME,
src/timespec.c-                          ts->tv_sec, ts->tv_nsec);

--- Additional comment from Anand Avati on 2015-08-12 06:39:00 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs: Pending - Porting log
messages to new framework) posted (#1) for review on master by Mohamed Ashiq
Liyazudeen (mliyazud at redhat.com)

--- Additional comment from Anand Avati on 2015-08-13 02:08:01 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs: Pending - Porting log
messages to new framework) posted (#2) for review on master by Mohamed Ashiq
Liyazudeen (mliyazud at redhat.com)

--- Additional comment from Anand Avati on 2015-08-24 10:08:45 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs: Porting log messages to
new framework) posted (#3) for review on master by Mohamed Ashiq Liyazudeen
(mliyazud at redhat.com)

--- Additional comment from Anand Avati on 2015-08-28 02:22:05 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs: Porting log messages to
new framework) posted (#4) for review on master by Mohamed Ashiq Liyazudeen
(mliyazud at redhat.com)

--- Additional comment from Anand Avati on 2015-08-31 03:31:58 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs:Porting log messages to
new framework) posted (#5) for review on master by Mohamed Ashiq Liyazudeen
(mliyazud at redhat.com)

--- Additional comment from Anand Avati on 2015-08-31 07:06:11 EDT ---

REVIEW: http://review.gluster.org/11896 (libglusterfs:Porting log messages to
new framework) posted (#6) for review on master by Mohamed Ashiq Liyazudeen
(mliyazud at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1241957
[Bug 1241957] [ TRACKER ] : Tracker for porting pending log messages
porting to new framework
https://bugzilla.redhat.com/show_bug.cgi?id=1242211
[Bug 1242211] libglusterfs: Pending - Porting log messages to new framework
https://bugzilla.redhat.com/show_bug.cgi?id=1252836
[Bug 1252836] libglusterfs: Pending - Porting log messages to new framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.