[Bugs] [Bug 1275906] New: Fix in afr transaction code

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1275906

            Bug ID: 1275906
           Summary: Fix in afr transaction code
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: gluster-afr
          Assignee: pkarampu at redhat.com
          Reporter: ravishankar at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1272362
            Blocks: 1273334
             Group: redhat



+++ This bug was initially created as a clone of Bug #1272362 +++

Description of problem:

Found while going through the code:

When winding the pre-op, transaction.pre_op[i] is set. If the pre-op fails,
transaction.failed_subvols[i] is set. If if fails on all chidren, we can
directly proceed to unlock (via afr_changelog_post_op_now) without trying
to wind the write, fail and then go to unlock.

--- Additional comment from Vijay Bellur on 2015-10-16 04:45:57 EDT ---

REVIEW: http://review.gluster.org/12368 (afr: do not wind write if pre-op fails
on all children) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-10-20 04:44:40 EDT ---

COMMIT: http://review.gluster.org/12368 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 7945121dda340ec8f25711b2ad3ca70b544de967
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Oct 16 06:23:29 2015 +0530

    afr: do not wind write if pre-op fails on all children

    1. When winding the pre-op, transaction.pre_op[i] is set. If the pre-op
fails,
    transaction.failed_subvols[i] is set. If if fails on all chidren, we can
    directly proceed to unlock (via afr_changelog_post_op_now) without trying
    to wind the write, fail and then go to unlock.

    2. 'fop_subvols' seems to be an unused variable, hence removing it.

    Change-Id: I9525628daf48082e979b0093fa0478934495e61f
    BUG: 1272362
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/12368
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Reviewed-by: Anuradha Talur <atalur at redhat.com>

--- Additional comment from Vijay Bellur on 2015-10-23 02:10:03 EDT ---

REVIEW: http://review.gluster.org/12415 (afr: wind writes only on subvols where
preop succeeded) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2015-10-26 04:29:11 EDT ---

COMMIT: http://review.gluster.org/12415 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit c7e30933f67f8ab8619ea28bb82e0907a26fe370
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Oct 23 11:19:30 2015 +0530

    afr: wind writes only on subvols where preop succeeded

    1. Call local->transaction.wind() only on subvols where pre-op
    succeeded.

    2. Update op_errno in afr_changelog_cbk call path. This fixes a bug in
    commit 7945121dda340ec8f25711b2ad3ca70b544de967 where we return EUCLEAN
    to the application if pre-op fails on all bricks.

    Change-Id: Iab8776e49a992e7a255314bba542742f7607f3ec
    BUG: 1272362
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/12415
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1272362
[Bug 1272362] Fix in afr transaction code
https://bugzilla.redhat.com/show_bug.cgi?id=1273334
[Bug 1273334] Fix in afr transaction code
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3spAPP1e4c&a=cc_unsubscribe