[Bugs] [Bug 1273334] Fix in afr transaction code

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 26 12:41:37 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1273334



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12399 committed in release-3.7 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit da9f8bd6e9421209243afeabbad350cc1d70fdc5
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon Oct 26 14:14:18 2015 +0530

    afr: fixes in transaction code

    Backport of http://review.gluster.org/#/c/12368/ and
    http://review.gluster.org/#/c/12415/

    1. When winding the pre-op, transaction.pre_op[i] is set. If the pre-op
    fails, transaction.failed_subvols[i] is set. If if fails on all chidren,
    we can directly proceed to unlock (via afr_changelog_post_op_now)
    without trying to wind the write, fail and then going to unlock.

    2. 'fop_subvols' seems to be an unused variable, hence removing it.

    3. Call local->transaction.wind() only on subvols where pre-op succeeded.

    Change-Id: I9525628daf48082e979b0093fa0478934495e61f
    BUG: 1273334
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/12399
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list