[Bugs] [Bug 1270769] quota/marker: dir count in inode quota is not atomic

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1270769



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12341 committed in release-3.7 by Raghavendra
G (rgowdapp at redhat.com) 
------
commit 130190a3e1f2226883284aedbd63a9505fd0b702
Author: vmallika <vmallika at redhat.com>
Date:   Wed Oct 7 15:24:46 2015 +0530

    quota/marker: dir_count accounting is not atomic

    This is a backport of http://review.gluster.org/#/c/11694/

    Consider below scenario:

    Quota enabled on pre-existing data
    Now quota-crawl process will start healing xattrs
    Now if write is performed where healing is not complete, there is a
    possibility that 'update txn' is started before 'create xattr txn', in
    this case dir count can be missed on a dir where quota size xattr is not
    yet created.

    Solution is to get size xattr and if xattr is missing, add 1 for
    dir_count, this requires one additional fop if done in marker during
    each update iteration
    Better solution is to us xattrop GF_XATTROP_ADD_ARRAY64_WITH_DEFAULT

    > Change-Id: Idc8978860a3914e70c98f96effeff52e9a24e6ba
    > BUG: 1243798
    > Signed-off-by: vmallika <vmallika at redhat.com>
    > Reviewed-on: http://review.gluster.org/11694
    > Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

    Change-Id: If553372c31093d86fabe5a2ae5044a2cff28c3dc
    BUG: 1270769
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/12341
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EkBJ42xpkx&a=cc_unsubscribe