[Bugs] [Bug 1243798] quota/marker: dir count in inode quota is not atomic

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 12 10:14:19 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1243798



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/11694 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit d4bd690adae7ce69594c3322d0d7a8e3cb4f7303
Author: vmallika <vmallika at redhat.com>
Date:   Wed Oct 7 15:24:46 2015 +0530

    quota/marker: dir_count accounting is not atomic

    Consider below scenario:

    Quota enabled on pre-existing data
    Now quota-crawl process will start healing xattrs
    Now if write is performed where healing is not complete, there is a
    possibility that 'update txn' is started before 'create xattr txn', in
    this case dir count can be missed on a dir where quota size xattr is not
    yet created.

    Solution is to get size xattr and if xattr is missing, add 1 for
    dir_count, this requires one additional fop if done in marker during
    each update iteration
    Better solution is to us xattrop GF_XATTROP_ADD_ARRAY64_WITH_DEFAULT

    Change-Id: Idc8978860a3914e70c98f96effeff52e9a24e6ba
    BUG: 1243798
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/11694
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Uep5eI3ccZ&a=cc_unsubscribe


More information about the Bugs mailing list