[Bugs] [Bug 1247910] New: Gluster peer probe with negative num

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1247910

            Bug ID: 1247910
           Summary: Gluster peer probe with negative num
           Product: GlusterFS
           Version: 3.7.0
         Component: cli
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: mliyazud at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    mselvaga at redhat.com, mzywusko at redhat.com,
                    ssamanta at redhat.com
        Depends On: 1242742



+++ This bug was initially created as a clone of Bug #1242742 +++

+++ This bug was initially created as a clone of Bug #1065613 +++

Description of problem:
The gluster peer probe command with invalid ips dont report that IP's can also
be a valid in usage.



[root at desktop8 /]# gluster peer status
Number of Peers: 0
[root at desktop8 /]# ifconfig -a
bash: ifconfig: command not found
[root at desktop8 /]# ifconfig
bash: ifconfig: command not found
[root at desktop8 /]# gluster peer status
Number of Peers: 0
[root at desktop8 /]# gluster peer probe server1
peer probe: failed: Probe returned with unknown errno 107
[root at desktop8 /]# gluster peer probe server223433
peer probe: failed: Probe returned with unknown errno 107
[root at desktop8 /]# gluster peer probe -1
-1 is an invalid address
Usage: peer probe <HOSTNAME> ----
[root at desktop8 /]


Version-Release number of selected component (if applicable):
[root at desktop8 /]# rpm -qa | grep glusterfs
glusterfs-3.5.0-0.5.beta3.fc20.x86_64
glusterfs-cli-3.5.0-0.5.beta3.fc20.x86_64
glusterfs-libs-3.5.0-0.5.beta3.fc20.x86_64
glusterfs-server-3.5.0-0.5.beta3.fc20.x86_64
glusterfs-fuse-3.5.0-0.5.beta3.fc20.x86_64
[root at desktop8 /]# 

How reproducible:


Steps to Reproduce:
1. Install glusterfs of above version 
2. Create bricks with XFS parttions and mount it
3. Issue gluster peer probe command with negative value

Actual results:
Usage: peer probe <HOSTNAME> 


Expected results:
Usage: peer probe <HOSTNAME>/IP address


Additional info:

--- Additional comment from Anand Avati on 2015-07-14 04:23:39 EDT ---

REVIEW: http://review.gluster.org/11657 (Gluster peer probe with negative num)
posted (#1) for review on master by Mohamed Ashiq (ashiq333 at gmail.com)

--- Additional comment from Anand Avati on 2015-07-14 05:12:25 EDT ---

REVIEW: http://review.gluster.org/11657 (cli : changing the gluster peer probe
message) posted (#2) for review on master by Mohamed Ashiq (ashiq333 at gmail.com)

--- Additional comment from Anand Avati on 2015-07-14 05:25:26 EDT ---

REVIEW: http://review.gluster.org/11657 (cli : changing the gluster peer probe
message) posted (#3) for review on master by Mohamed Ashiq (ashiq333 at gmail.com)

--- Additional comment from Anand Avati on 2015-07-14 06:58:31 EDT ---

REVIEW: http://review.gluster.org/11657 (cli : changing the gluster peer probe
message) posted (#4) for review on master by Mohamed Ashiq (ashiq333 at gmail.com)

--- Additional comment from Anand Avati on 2015-07-28 04:41:30 EDT ---

COMMIT: http://review.gluster.org/11657 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 746f23ce055f7beed20aa4038f61ad5bdd84419f
Author: Mohamed Ashiq Liyazudeen <mliyazud at redhat.com>
Date:   Tue Jul 14 12:24:21 2015 +0530

    cli : changing the gluster peer probe message

    The gluster peer probe command with invalid ips dont report that
    IP's can also be a valid in usage.

    Change-Id: I8f58341a2b76369ccf62f88ca0ecd8a9a9529af6
    BUG: 1242742
    Signed-off-by: Mohamed Ashiq Liyazudeen <mliyazud at redhat.com>
    Reviewed-on: http://review.gluster.org/11657
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy at gmail.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>

--- Additional comment from Anand Avati on 2015-07-29 04:04:42 EDT ---

REVIEW: http://review.gluster.org/11786 (cli : changing the gluster peer probe
message) posted (#1) for review on release-3.7 by Mohamed Ashiq Liyazudeen
(mliyazud at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1242742
[Bug 1242742] Gluster peer probe with negative num
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.