[Bugs] [Bug 1065619] gluster peer probe on localhost should fail with appropriate return value

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1065619

SATHEESARAN <sasundar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|NOTABUG                     |---
           Keywords|                            |Reopened



--- Comment #5 from SATHEESARAN <sasundar at redhat.com> ---
(In reply to Manikandan from comment #4)
> Hi,
> By definition, a "peer" is not the system itself. It refers to the system in
> the same pool, but not itself. So, localhost will be always missing and it
> is the expected behaviour.
> Instead, one can use "gluster pool list" to see all the systems in the
> trusted pool"

I agree that this is the expected behaviour. But if you look at it more closer,
you can realize the problem.

When a user tries to probe a same host ( say, by mistake ),
gluster cli returns the error messages as follows :

"peer probe: success. Probe on localhost not needed"

Note: gluster cli says, 'peer probe success'

When you check the return value.

<snip>
# echo $?
0
</snip>

Note: return value 0 means success.

Ideal expected behaviour should be :
1. When you probe a localhost, gluster cli should throw error message -
"Probe on localhost not needed"

2. Return value should not be 0

With this information, I re-open this bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.