[Bugs] [Bug 1242734] New: GlusterD crashes when management encryption is enabled

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1242734

            Bug ID: 1242734
           Summary: GlusterD crashes when management encryption is enabled
           Product: GlusterFS
           Version: 3.7.2
         Component: rpc
          Assignee: bugs at gluster.org
          Reporter: kaushal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1242570
            Blocks: 1233025 (glusterfs-3.7.3)



+++ This bug was initially created as a clone of Bug #1242570 +++

Two issues in socket_poller, the polling function used by SSL own-thread,
caused GlusterD to crash when management encryption is enabled.

Issue 1
-------
socket_poller calls functions which require THIS to be set. But, THIS
was being set conditionally. Because of this, functions could sometimes
be called without THIS being set. For example, rpc_transport_notify
could be called for an accepted client socket without THIS being set, as
THIS was only set it the transport wasn't yet connected. This would
cause the process to crash when THIS was accessed by the called
functions.

Issue 2
-------
DISCONNECT notify was being sent on the listener transport instead of
the client transport. The DISCONNECT event was converted to a
LISTENER_DEAD event in rpcsvc_handle_disconnect, as it could not find
the listener socket of the listener socket. GlusterD was notified of a
LISTENER_DEAD event instead of a DISCONNECT and failed to remove the
client transport from its xprt_list. The transport would subsequently
be freed, leaving the xprt_list with a corrupted/invalid entry. Later,
when GlusterD would iterate over the xprt_list to send notifications, it
would crash when the invalid entry was accessed.

--- Additional comment from Anand Avati on 2015-07-13 21:04:25 IST ---

REVIEW: http://review.gluster.org/11650 (rpc-transport: socket_poller fixes for
proper working of mgmt encryption) posted (#1) for review on master by Kaushal
M (kaushal at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1233025
[Bug 1233025] GlusterFS 3.7.3 tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1242570
[Bug 1242570] GlusterD crashes when management encryption is enabled
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.