[Bugs] [Bug 1238167] New: memory corruption in the way we maintain migration information in inodes.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1238167

            Bug ID: 1238167
           Summary: memory corruption in the way we maintain migration
                    information in inodes.
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: gluster-dht
          Assignee: rhs-bugs at redhat.com
          Reporter: rgowdapp at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1235927
            Blocks: 1235928



+++ This bug was initially created as a clone of Bug #1235927 +++

Description of problem:
In dht_migration_complete_check_task,

        ret = inode_ctx_reset1 (inode, this, &tmp_miginfo);
        if (tmp_miginfo) {
                GF_FREE (tmp_miginfo);
                goto out;
        }

However, another fop might be still using miginfo while we free it. The correct
way to solve this is to use refcounting mechanism of memory management.

Version-Release number of selected component (if applicable):


How reproducible:

Found through code-review. Its a race that can happen while doing parallel
operations on a file during migration. Since its a race, it might not be
reproducible consistently

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-06-26 02:25:28 EDT ---

REVIEW: http://review.gluster.org/11418 (cluster/dht: use refcount to manage
memory used to store migration information.) posted (#1) for review on master
by Raghavendra G (rgowdapp at redhat.com)

--- Additional comment from Anand Avati on 2015-06-29 00:58:03 EDT ---

REVIEW: http://review.gluster.org/11418 (cluster/dht: use refcount to manage
memory used to store migration information.) posted (#2) for review on master
by Raghavendra G (rgowdapp at redhat.com)

--- Additional comment from Anand Avati on 2015-06-30 00:18:36 EDT ---

REVIEW: http://review.gluster.org/11418 (cluster/dht: use refcount to manage
memory used to store migration information.) posted (#3) for review on master
by Raghavendra G (rgowdapp at redhat.com)

--- Additional comment from Anand Avati on 2015-06-30 07:50:59 EDT ---

REVIEW: http://review.gluster.org/11418 (cluster/dht: use refcount to manage
memory used to store migration information.) posted (#4) for review on master
by Raghavendra G (rgowdapp at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1235927
[Bug 1235927] memory corruption in the way we maintain migration
information in inodes.
https://bugzilla.redhat.com/show_bug.cgi?id=1235928
[Bug 1235928] memory corruption in the way we maintain migration
information in inodes.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BcuzcowtxQ&a=cc_unsubscribe