[Bugs] [Bug 1292254] hook script for CTDB should not change Samba config

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1292254



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/12986 committed in release-3.7 by Raghavendra
Talur (rtalur at redhat.com) 
------
commit f4357fdaca9175438f1168fcd07dd963eae4c4e2
Author: Michael Adam <obnox at samba.org>
Date:   Wed Dec 9 18:57:59 2015 +0100

    hook-scripts: don't let ctdb script change samba config

    There are several reasons why the behaviour in
    the hook scripts was bad:

    1. A samba installation is clustered or non-clustered.
       That does not change because of the availability
       of the CTDB lock-volume. If the lock-volume is not
       available (and hence CTDB is not available or not
       healthy), then Samba won't be operational. But turning
       it into a non-clustered Samba-installation can in
       the worst case lead to data corruption if clients
       manage to access the same files (on share volumes).
       Hence 'clustering = yes/no' in Samba's config should
       not be touched.

       In particular, Samba should not be stopped/started by
       the hook script. If needed, then ctdb will take care
       of it.

    2. Changing the idmap configuration is potentially
       dangerous as well. In particular the used tdb2
       backend is legacy nowadays and should not be used
       any more in new installs. (I stems from the times
       when ctdb could not host persistent databases.)
       Changing the idmap can result in loss of access
       to files or in giving access to files where it is
       not intended.

    3. The pattern used for detecting need for change is
       fragile. It may or may not play well possible
       manual changes to smb.conf.

    This change removes the parts that change the smb.conf
    file and start or stop Samba from the S29CTDB* hook scripts.

    > Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
    > BUG: 1290151
    > Signed-off-by: Michael Adam <obnox at samba.org>
    > Reviewed-on: http://review.gluster.org/12930
    > Tested-by: Gluster Build System <jenkins at build.gluster.com>
    > Reviewed-by: Raghavendra Talur <rtalur at redhat.com>

    (cherry picked from commit 27c16d6da82876a689dfba53b8d45c3a3a657954)

    Change-Id: Ie1f787cebb5f6da1a658f7dead879fa854901ef5
    BUG: 1292254
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-on: http://review.gluster.org/12986
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra Talur <rtalur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NsSjiCm5VM&a=cc_unsubscribe