[Bugs] [Bug 1292697] New: Symlinks Rename fails in Symlink not exists in Slave

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1292697

            Bug ID: 1292697
           Summary: Symlinks Rename fails in Symlink not exists in Slave
           Product: GlusterFS
           Version: 3.7.6
         Component: geo-replication
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1289859



+++ This bug was initially created as a clone of Bug #1289859 +++

Description of problem:
If Symlink creation failed in Slave and then it is renamed in Master. Geo-rep
session goes to Faulty while renaming Symlink.

How reproducible:


Steps to Reproduce:
1. Create a file in Master(say f1)
2. Create symlink s1 in Master(say s1. ln -s f1 s1) and wait till it syncs to
Slave. 
3. Wait for some time and add data to f1 and wait till it syncs to slave.(Just
to make sure that rename will get recorded in different Changelog file)
4. Delete symlink in Slave
5. Rename symlink in Master
6. Check the status of Geo-replication.

Actual results:
Geo-rep session goes to Faulty

Expected results:
Should not go to Faulty

Additional info:

--- Additional comment from Vijay Bellur on 2015-12-09 03:27:40 EST ---

REVIEW: http://review.gluster.org/12917 (geo-rep: Symlink Rename issue) posted
(#2) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-10 04:25:59 EST ---

REVIEW: http://review.gluster.org/12917 (geo-rep: Symlink Rename issue) posted
(#3) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-18 00:46:42 EST ---

COMMIT: http://review.gluster.org/12917 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit 3151194fad1aed3ab340b53aeeb4e8d131538d12
Author: Aravinda VK <avishwan at redhat.com>
Date:   Wed Dec 9 13:46:17 2015 +0530

    geo-rep: Symlink Rename issue

    If ENTRY creation failed for symlink in Slave and symlink
    renamed in Master. If Source not exists to Rename in Slave
    Geo-rep interprets as Create of Target file. Geo-rep sends blob
    of regular file to create symlink instead of sending blob of
    symlink.

    With this patch, Geo-rep identifies symlink and sends respective
    blob.

    BUG: 1289859
    Change-Id: If9351974d1945141a1d3abb838b7d0de7591e48e
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/12917
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-by: Milind Changire <mchangir at redhat.com>
    Tested-by: Milind Changire <mchangir at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1289859
[Bug 1289859] Symlinks Rename fails in Symlink not exists in Slave
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.